Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(examples): improve p/moul/txlink #3682

Merged
merged 4 commits into from
Feb 4, 2025

Conversation

moul
Copy link
Member

@moul moul commented Feb 4, 2025

  • Escape args properly.

Related with #3668

@moul moul self-assigned this Feb 4, 2025
@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Feb 4, 2025
@moul moul force-pushed the dev/moul/txlink-improve branch from a9f9fad to 76fc676 Compare February 4, 2025 09:54
@github-actions github-actions bot added the 📦 ⛰️ gno.land Issues or PRs gno.land package related label Feb 4, 2025
@moul moul changed the title dev/moul/txlink improve chore(examples): improve p/moul/txlink Feb 4, 2025
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Feb 4, 2025

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 The pull request was created from a fork (head branch repo: moul/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

@moul moul force-pushed the dev/moul/txlink-improve branch from b4013f2 to 38c3d30 Compare February 4, 2025 09:57
@moul moul force-pushed the dev/moul/txlink-improve branch from d908aa0 to fdd704e Compare February 4, 2025 09:57
@moul moul marked this pull request as ready for review February 4, 2025 09:58
@moul moul requested review from jeronimoalbi and leohhhn February 4, 2025 09:58
@moul moul mentioned this pull request Feb 4, 2025
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@moul moul merged commit f847090 into gnolang:master Feb 4, 2025
56 checks passed
@moul moul deleted the dev/moul/txlink-improve branch February 4, 2025 12:07
petar-dambovaliev pushed a commit that referenced this pull request Feb 4, 2025
- Escape args properly.

Related with #3668

---------

Signed-off-by: moul <[email protected]>
Co-authored-by: Jerónimo Albi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 ⛰️ gno.land Issues or PRs gno.land package related 🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants