-
Notifications
You must be signed in to change notification settings - Fork 391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add r/moul/present #3668
Merged
Merged
feat: add r/moul/present #3668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
Signed-off-by: moul <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Escape args. Signed-off-by: moul <[email protected]>
moul
added a commit
that referenced
this pull request
Feb 4, 2025
- Escape args properly. Related with #3668 --------- Signed-off-by: moul <[email protected]> Co-authored-by: Jerónimo Albi <[email protected]>
petar-dambovaliev
pushed a commit
that referenced
this pull request
Feb 4, 2025
- Escape args properly. Related with #3668 --------- Signed-off-by: moul <[email protected]> Co-authored-by: Jerónimo Albi <[email protected]>
jeronimoalbi
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This realm is a good example of reusing and integrating some of my recently added libraries:
p/moul/md
feat: addp/moul/{md,debug,web25}
+ updater/moul/home
#2819p/moul/mdtable
feat: add p/moul/mdtable #3100p/moul/realmpath
feat: add p/moul/realmpath #3257p/moul/txlink
chore: refactor txlink in order to extend it #3289p/moul/collection
feat(examples): add p/moul/collection #3321p/demo/avl/pager
feat: add p/avl/pager #2584It helped me identify that
txlink
was not escaping the arguments, which resulted in invalid links. (fixed in #3682)Additionally, it provided me with a better understanding of:
p/moul/md
API, particularly regarding"\n"
handlingp/moul/collection
Demo:
CleanShot.2025-02-03.at.21.26.46.mp4
I also suggest you to look at the
filetest.gno
file.I believe we should proceed with the merge, to inspire others to create similar composed realms.
However, I have a few improvement ideas:
p/moul/present
.r/coreteam/present
to create a hub for presentations from all teammates, or the opposite: maker/coreteam/present
the content source and allowr/moul/present
to display a subset whereauthor="moul"
What are your thoughts?p/moul/md
and possibly newp/
generic utilities.Depenes on #3682