Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add r/moul/present #3668

Merged
merged 22 commits into from
Feb 4, 2025
Merged

feat: add r/moul/present #3668

merged 22 commits into from
Feb 4, 2025

Conversation

moul
Copy link
Member

@moul moul commented Feb 2, 2025

This realm is a good example of reusing and integrating some of my recently added libraries:

It helped me identify that txlink was not escaping the arguments, which resulted in invalid links. (fixed in #3682)

Additionally, it provided me with a better understanding of:

  • The shortcomings of the p/moul/md API, particularly regarding "\n" handling
  • The need for improved management of the pager for p/moul/collection
  • What kind of UI improvements we could need on gnoweb. META Gnoweb UI Improvements #3355

Demo:

CleanShot.2025-02-03.at.21.26.46.mp4

I also suggest you to look at the filetest.gno file.

I believe we should proceed with the merge, to inspire others to create similar composed realms.

However, I have a few improvement ideas:

  1. Extract most of the generic logic into a p/moul/present.
  2. Consider either making r/moul/present importable by r/coreteam/present to create a hub for presentations from all teammates, or the opposite: make r/coreteam/present the content source and allow r/moul/present to display a subset where author="moul" What are your thoughts?
  3. Clean up the code using an improved p/moul/md and possibly new p/ generic utilities.

Depenes on #3682

@moul moul self-assigned this Feb 2, 2025
@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Feb 2, 2025
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Feb 2, 2025

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 The pull request was created from a fork (head branch repo: moul/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

Signed-off-by: moul <[email protected]>
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

moul added 9 commits February 3, 2025 18:14
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
@moul moul changed the title dev/moul/present feat: add r/moul/present Feb 3, 2025
Signed-off-by: moul <[email protected]>
@moul moul marked this pull request as ready for review February 3, 2025 20:37
@moul moul requested a review from aeddi February 4, 2025 09:47
moul added a commit that referenced this pull request Feb 4, 2025
- Escape args properly.

Related with #3668

---------

Signed-off-by: moul <[email protected]>
Co-authored-by: Jerónimo Albi <[email protected]>
petar-dambovaliev pushed a commit that referenced this pull request Feb 4, 2025
- Escape args properly.

Related with #3668

---------

Signed-off-by: moul <[email protected]>
Co-authored-by: Jerónimo Albi <[email protected]>
@moul moul merged commit 8410060 into gnolang:master Feb 4, 2025
59 checks passed
@moul moul deleted the dev/moul/present branch February 4, 2025 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants