Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add r/demo/atomicswap #2510
feat: add r/demo/atomicswap #2510
Changes from all commits
af8f629
9b7190e
1b0a95f
6b89115
b8a8282
23f7173
b0397ed
b1254a7
59443ee
d317eaa
6a41a93
3ab2e5a
d23ab40
08d0c11
ade3d05
437df89
b45a63d
ae76c6e
552f06b
25e3d6e
82219a4
aa51902
be4615c
9ec3353
d1af9ce
360c0c8
34b35b9
a854c26
27e979f
d8438d2
5d97b41
d985d4f
9eeb026
2a3c3ac
2d83f2b
42b2061
d26b7c7
0ec05b6
15f13ef
2bcd69f
689e42b
16b9a15
070f2cb
6316e48
3067fa0
caf38cd
9df618e
5343784
d8bb614
f1dc45b
c47a2e8
79d9404
7a7c65e
b05e615
b1a2490
948bb24
5c152d2
b22cd05
e4249a1
7110526
a81f968
b92dd68
23127d6
cddf395
6435ef0
9ff36e0
8a09fd7
43b46b5
06c87e5
0e1b7a7
28b015a
8a352d4
191c779
4f21fcb
f926979
e28b995
f99654e
3a5acf1
a21ddd5
68f8d61
db1e4a6
4b298d5
27a2749
659afe7
bb88a02
b662b15
e3d4c8f
02faa9c
7a859a8
90a15aa
cb84fc5
e2dca03
b7561f2
93ab638
2a8ef49
197b3a5
40ff64a
8b5f271
6b5f2d8
e307585
3ef98ee
4b9509d
7a45b94
1c4ceaf
71481e7
d5f9528
43f113d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is Solidity's style. While I appreciate the conciseness, do you think we should stick to the Go idiomatic way of checking for errors? ie
if err:= ...; err!=nil {panic(err)}
Not sure what should be the way forward.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is Go too, not very famous, and usually found only in mains or "scripts." I believe it will become more common in Gno realms.
For instance, here is a Go package I wrote several years ago because I was accustomed to having this helper in all my mains: https://pkg.go.dev/moul.io/u#CheckErr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: can be written without the
else
block enclosing the codeThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I won't fix it myself since I prefer this version to resemble a "switch case" with clear responsibilities. However, if someone believes it's important enough, feel free to send a suggestion that I will approve.