Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add r/demo/atomicswap #2510

Open
wants to merge 97 commits into
base: master
Choose a base branch
from
Open

feat: add r/demo/atomicswap #2510

wants to merge 97 commits into from
+701 −0

Conversation

moul
Copy link
Member

@moul moul commented Jul 5, 2024 •
edited
Loading

  • implement
  • unit test / txtar
  • question: ugnot or grc20 or both? Maybe it’s time to encourage using wugnot.
    -> both, with a callback mechanism.
  • question: p+r or just r?
    -> just r, and a single file. let's do it more!
  • make the API gnokey compatible + add Render.

Depends on #3397 (cherry-picked)
Depends on #2529 (cherry-picked)
Depends on #2549 (cherry-picked)
Depends on #2551
Closes #2549

@moul moul self-assigned this Jul 5, 2024
@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Jul 5, 2024
@moul
chore: fixup
9b7190e 
Signed-off-by: moul <[email protected]>
@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label Jul 5, 2024
@moul
chore: fixup
1b0a95f 
Signed-off-by: moul <[email protected]>
@codecov Codecov
Copy link

codecov bot commented Jul 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@moul
Copy link
Member Author

moul commented Jul 5, 2024

I think i'll try to be more grc20-centric for my demos. In involves writing some helpers to show how to actually come with gnot tokens, wrap then with wugnot. But also writing more and more grc20 examples: stupid ones, testing-purpose ones, etc.

@moul moul mentioned this pull request Jul 5, 2024
Merged
jaekwon and others added 16 commits July 5, 2024 15:34
@jaekwon
override pv and rlm if method receiver has one
b8a8282
@jaekwon
add tests
23f7173
@jaekwon
Merge branch 'master' into dev/jae/boundmethodrealm
b0397ed
@moul
chore: add missing gno.mod files
b1254a7 
Signed-off-by: moul <[email protected]>
@moul
chore: fixup
59443ee 
Signed-off-by: moul <[email protected]>
@moul
chore: fixup
d317eaa 
Signed-off-by: moul <[email protected]>
@jaekwon
resave after init
6a41a93
@moul
chore: fixup
3ab2e5a 
Signed-off-by: moul <[email protected]>
@moul
Merge remote-tracking branch 'origin/dev/jae/boundmethodrealm' into d…
d23ab40 
…ev/moul/atomicswap
@moul
Merge branch 'master' into dev/moul/atomicswap
08d0c11
@moul
Merge branch 'master' into dev/moul/atomicswap
ade3d05
@moul
chore: fixup
437df89 
Signed-off-by: moul <[email protected]>
@moul
chore(examples): make lint -> verbose
b45a63d 
Signed-off-by: moul <[email protected]>
@moul
chore: fixup
ae76c6e 
Signed-off-by: moul <[email protected]>
@moul
chore: fixup
552f06b 
Signed-off-by: moul <[email protected]>
@moul
chore: fixup
25e3d6e 
Signed-off-by: moul <[email protected]>
@moul moul marked this pull request as ready for review July 6, 2024 20:26
@moul moul requested review from thehowl and a team as code owners July 6, 2024 20:26
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Nov 28, 2024 •
edited
Loading

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 The pull request was created from a fork (head branch repo: moul/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request
Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

moul added a commit that referenced this pull request Dec 3, 2024
@moul
feat: add grc20reg that works... today (#3135)
bc44a39 
- [x] Switch to storing a `type XXX func() grc20.Token` instead of a
`grc20.Token` directly.
-  [x] Implement `grc20reg`.  
- [x] Add new tests in `gnovm/tests` to demonstrate the current VM's
management of the cross-realm feature and support potential changes in
#2743.
- [x] Create a demo in `atomicswap` or a similar application.
(#2510 (comment))
-  [x] Try using a `Token.Getter()` helper.  (Works! f99654e)
- [ ] Demonstrate how to manage "disappearing" functions during garbage
collection by checking if the function pointer is nil or non-resolvable.

Alternative to #2516  
NOT(!) depending on #2743

---------

Signed-off-by: moul <[email protected]>
r3v4s pushed a commit to gnoswap-labs/gno that referenced this pull request Dec 10, 2024
@moul @r3v4s
feat: add grc20reg that works... today (gnolang#3135)
d789184 
- [x] Switch to storing a `type XXX func() grc20.Token` instead of a
`grc20.Token` directly.
-  [x] Implement `grc20reg`.  
- [x] Add new tests in `gnovm/tests` to demonstrate the current VM's
management of the cross-realm feature and support potential changes in
gnolang#2743.
- [x] Create a demo in `atomicswap` or a similar application.
(gnolang#2510 (comment))
-  [x] Try using a `Token.Getter()` helper.  (Works! f99654e)
- [ ] Demonstrate how to manage "disappearing" functions during garbage
collection by checking if the function pointer is nil or non-resolvable.

Alternative to gnolang#2516  
NOT(!) depending on gnolang#2743

---------

Signed-off-by: moul <[email protected]>
@n0izn0iz n0izn0iz mentioned this pull request Jan 6, 2025
Draft
moul
moul commented Jan 6, 2025
View reviewed changes
gnovm/stdlibs/std/coins.gno Outdated Show resolved Hide resolved
albttx pushed a commit that referenced this pull request Jan 10, 2025
@moul @albttx
feat: add grc20reg that works... today (#3135)
8f55b66 
- [x] Switch to storing a `type XXX func() grc20.Token` instead of a
`grc20.Token` directly.
-  [x] Implement `grc20reg`.  
- [x] Add new tests in `gnovm/tests` to demonstrate the current VM's
management of the cross-realm feature and support potential changes in
#2743.
- [x] Create a demo in `atomicswap` or a similar application.
(#2510 (comment))
-  [x] Try using a `Token.Getter()` helper.  (Works! f99654e)
- [ ] Demonstrate how to manage "disappearing" functions during garbage
collection by checking if the function pointer is nil or non-resolvable.

Alternative to #2516  
NOT(!) depending on #2743

---------

Signed-off-by: moul <[email protected]>
moul added 2 commits January 10, 2025 18:14
@moul
chore: fixup
197b3a5 
Signed-off-by: moul <[email protected]>
@moul
chore: fixup
40ff64a 
Signed-off-by: moul <[email protected]>
@moul moul requested review from leohhhn, n0izn0iz and notJoon and removed request for mvertes, thehowl and a team January 10, 2025 18:25
@moul
Copy link
Member Author

moul commented Jan 10, 2025

Ready for review.

@moul moul removed the don't merge Please don't merge this functionality temporarily label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zivkovicmilos zivkovicmilos Awaiting requested review from zivkovicmilos

@leohhhn leohhhn Awaiting requested review from leohhhn

@n0izn0iz n0izn0iz Awaiting requested review from n0izn0iz

@notJoon notJoon Awaiting requested review from notJoon

At least 1 approving review is required to merge this pull request.

Assignees

@moul moul

Labels
📦 ⛰️ gno.land Issues or PRs gno.land package related 📦 🤖 gnovm Issues or PRs gnovm related 🧾 package/realm Tag used for new Realms or Packages.
Projects
💪 Bounties & Worx
Status: No status
😎 Manfred's Board
Status: 🙏🏻 To Delegate
🧐 Review Meeting
Status: No status
🧙‍♂️gno.land core team
Status: In Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@moul @Gno2D2 @jaekwon