Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove requirements.txt, use Pipfile instead #94

Merged
merged 5 commits into from
Jul 1, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/python.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,15 @@ jobs:
with:
python-version: ${{ env.PYTHON_VERSION }}

- name: Install pipenv
run: pip install pipenv

- name: install dependencies
run: pip install -r requirements.txt
run: pipenv install --dev

- name: run black formatter
run: black --check .
run: pipenv run black --check .

- name: run flake8 linter
# Ignore linting errors that the black formatter is opiniated about
run: flake8 --ignore E501,W503 .

- name: run bandit security scan
run: bandit -r .
run: pipenv run flake8 --ignore E501,W503 .
4 changes: 4 additions & 0 deletions Pipfile
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,9 @@ requests = "~=2.32.3"
jira = "~=3.0.0"
logging-formatter-anticrlf = "~=1.2.1"

[dev-packages]
black = "~=24.4.2"
flake8 = "~=7.1.0"

[requires]
python_version = "3"
lcartey marked this conversation as resolved.
Show resolved Hide resolved
6 changes: 4 additions & 2 deletions action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,11 @@ runs:
INPUTS_ISSUE_END_STATE: ${{ inputs.issue_end_state }}
INPUTS_ISSUE_REOPEN_STATE: ${{ inputs.issue_reopen_state }}
run: |
pip3 install -r requirements.txt
pip3 install pipenv
pipenv install
REPOSITORY_NAME="$(echo "$GITHUB_REPOSITORY" | cut -d/ -f 2)"
./gh2jira sync \
# Run pipenv from the temporary directory
pipenv run ./gh2jira sync \
--gh-url "$GITHUB_API_URL" \
--gh-token "$INPUTS_GITHUB_TOKEN" \
--gh-org "$GITHUB_REPOSITORY_OWNER" \
Expand Down
7 changes: 0 additions & 7 deletions requirements.txt

This file was deleted.