Remove requirements.txt, use Pipfile instead
#94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theztefan
reviewed
Jun 28, 2024
There was a problem hiding this comment.
@lcartey couple of comments/suggestions left. Mainly I think we can remove bandit scan of the code.
As for the requirements.txt -> Pipfile switch, I am personally fine with it. We should benefit from the improvements that pipenv brings.
|
FYI, while doing this, can we 🔥 through the outstanding dependabot updates? |
theztefan
approved these changes
Jul 1, 2024
There was a problem hiding this comment.
lgtm 🚀
@jbjonesjr this PR addresses the two open Dependabot alerts for the vulnerable requests version.
This provides a single source of truth for the dependencies for the project.
lcartey
force-pushed
the
lcartey/remove-requirements
branch
from
9b515ec to
a5e42a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently have both a
Pipfileandrequirements.txtfile in this repository, which specify different dependency versions. This PR standardises on thePipfileandpipenvto give a single source of truth for the dependencies for the project. ThePipfilewas chosen as this is already the recommended way of running the integration specified in the documentation.