Skip to content
This repository has been archived by the owner on May 7, 2018. It is now read-only.

Updating Octokit to the 0.24.0 #3

Open
wants to merge 32 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
0a882ce
introduce Contributor Covenant template
shiftkey Mar 17, 2016
e89e7f9
add mention in README
shiftkey May 11, 2016
4bd3a44
Merge pull request #1484 from octokit/release
shiftkey Oct 7, 2016
4be25ba
Add missing `SecurityCritical` attribute
M-Zuber Oct 13, 2016
10d2632
Missing Milestone fields (#1489)
StanleyGoldman Oct 13, 2016
80615e5
Correcting return type in ObservableEventsClient
StanleyGoldman Oct 9, 2016
7fb35ca
Fixing unit tests
StanleyGoldman Oct 16, 2016
754e937
Correcting convention unit tests
StanleyGoldman Oct 16, 2016
9265350
Additional test fixes
StanleyGoldman Oct 16, 2016
ea64789
Merge pull request #1493 from M-Zuber/fix-1471
shiftkey Oct 16, 2016
e2af971
Merge pull request #1490 from StanleyGoldman/fixes/issue-events
shiftkey Oct 19, 2016
e60d727
[UserUpdate] - Fix typo.
ivandrofly Oct 29, 2016
091248b
Merge pull request #1498 from ivandrofly/patch-typo
shiftkey Oct 30, 2016
97dee1e
Deployments tidy up [WIP] (#1497)
ivandrofly Nov 21, 2016
88e5342
Allow base64 content for create/update file (#1488)
Nov 21, 2016
195de68
Added a get all organizations method (#1469)
malamour-work Nov 21, 2016
155073b
[WIP] Rename Comment to ReviewComment (#1520)
bmeverett Dec 31, 2016
49c2d52
Add ApiInfo Rate limiting description to Getting Started (#1524)
SeanKilleen Jan 1, 2017
cf0eddd
Fix IssueCommentClient #1500 (#1501)
pjc0247 Jan 7, 2017
3a1070f
Add docs snippet for label coloring (#1530)
SeanKilleen Jan 9, 2017
49156a0
changed the email address
shiftkey Jan 9, 2017
38f0826
Merge pull request #1197 from octokit/shiftkey-code-of-conduct
haacked Jan 9, 2017
4e16d93
Modified code comment for RepositoryContentInfo.Sha (#1534)
JohnGoldsmith Jan 11, 2017
b4fad9b
Add multiple assignees to issues (#1339)
martinscholz83 Jan 11, 2017
4cec3a6
Introduce AbuseException (#1528)
SeanKilleen Jan 11, 2017
eeb98c7
Add Missing Event Types (#1536)
lynnfaraday Jan 13, 2017
fcee797
Add Id for PullRequest.cs (#1537)
YunLi1988 Jan 14, 2017
620b1b9
Add missing fields to Repository class - HasPages, SubscribersCount, …
ryangribble Jan 15, 2017
01a2d97
Update ApiErrorMessageSafe to return null for empty and whitespace st…
SeanKilleen Jan 16, 2017
aa80eaa
Add "Bot" AccountType, was causing a deserialization exception when r…
ryangribble Jan 16, 2017
3c81893
Release v0.24 - A Sight For Sore Eyes (#1539)
ryangribble Jan 17, 2017
40c8b70
Merge tag 'v0.24.0' into octokit-0.24
shana Jul 3, 2017
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
74 changes: 74 additions & 0 deletions CODE_OF_CONDUCT.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,74 @@
# Contributor Covenant Code of Conduct

## Our Pledge

In the interest of fostering an open and welcoming environment, we as
contributors and maintainers pledge to making participation in our project and
our community a harassment-free experience for everyone, regardless of age, body
size, disability, ethnicity, gender identity and expression, level of experience,
nationality, personal appearance, race, religion, or sexual identity and
orientation.

## Our Standards

Examples of behavior that contributes to creating a positive environment
include:

* Using welcoming and inclusive language
* Being respectful of differing viewpoints and experiences
* Gracefully accepting constructive criticism
* Focusing on what is best for the community
* Showing empathy towards other community members

Examples of unacceptable behavior by participants include:

* The use of sexualized language or imagery and unwelcome sexual attention or
advances
* Trolling, insulting/derogatory comments, and personal or political attacks
* Public or private harassment
* Publishing others' private information, such as a physical or electronic
address, without explicit permission
* Other conduct which could reasonably be considered inappropriate in a
professional setting

## Our Responsibilities

Project maintainers are responsible for clarifying the standards of acceptable
behavior and are expected to take appropriate and fair corrective action in
response to any instances of unacceptable behavior.

Project maintainers have the right and responsibility to remove, edit, or
reject comments, commits, code, wiki edits, issues, and other contributions
that are not aligned to this Code of Conduct, or to ban temporarily or
permanently any contributor for other behaviors that they deem inappropriate,
threatening, offensive, or harmful.

## Scope

This Code of Conduct applies both within project spaces and in public spaces
when an individual is representing the project or its community. Examples of
representing a project or community include using an official project e-mail
address, posting via an official social media account, or acting as an appointed
representative at an online or offline event. Representation of a project may be
further defined and clarified by project maintainers.

## Enforcement

Instances of abusive, harassing, or otherwise unacceptable behavior may be
reported by contacting the project team at [[email protected]](mailto:[email protected]). All
complaints will be reviewed and investigated and will result in a response that
is deemed necessary and appropriate to the circumstances. The project team is
obligated to maintain confidentiality with regard to the reporter of an incident.
Further details of specific enforcement policies may be posted separately.

Project maintainers who do not follow or enforce the Code of Conduct in good
faith may face temporary or permanent repercussions as determined by other
members of the project's leadership.

## Attribution

This Code of Conduct is adapted from the [Contributor Covenant][homepage], version 1.4,
available at [http://contributor-covenant.org/version/1/4][version]

[homepage]: http://contributor-covenant.org
[version]: http://contributor-covenant.org/version/1/4/
20 changes: 20 additions & 0 deletions Octokit.Reactive/Clients/IObservableAssigneesClient.cs
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,26 @@ public interface IObservableAssigneesClient
/// <param name="assignee">Username of the prospective assignee</param>
IObservable<bool> CheckAssignee(string owner, string name, string assignee);

/// <summary>
/// Add assignees to a specified Issue.
/// </summary>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The issue number</param>
/// <param name="assignees">List of names of assignees to add</param>
/// <returns></returns>
IObservable<Issue> AddAssignees(string owner, string name, int number, AssigneesUpdate assignees);

/// <summary>
/// Remove assignees from a specified Issue.
/// </summary>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The issue number</param>
/// <param name="assignees">List of assignees to remove </param>
/// <returns></returns>
IObservable<Issue> RemoveAssignees(string owner, string name, int number, AssigneesUpdate assignees);

/// <summary>
/// Checks to see if a user is an assignee for a repository.
/// </summary>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ public interface IObservableCommitCommentReactionsClient
/// <param name="number">The comment id</param>
/// <returns></returns>
IObservable<Reaction> GetAll(string owner, string name, int number);

/// <summary>
/// List reactions for a specified Commit Comment
/// </summary>
Expand Down
2 changes: 1 addition & 1 deletion Octokit.Reactive/Clients/IObservableCommitStatusClient.cs
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ public interface IObservableCommitStatusClient
/// <param name="name">The name of the repository</param>
/// <param name="reference">The reference (SHA, branch name, or tag name) to list commits for</param>
IObservable<CommitStatus> GetAll(string owner, string name, string reference);

/// <summary>
/// Retrieves commit statuses for the specified reference. A reference can be a commit SHA, a branch name, or
/// a tag name.
Expand Down
2 changes: 1 addition & 1 deletion Octokit.Reactive/Clients/IObservableCommitsClient.cs
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ public interface IObservableCommitsClient
/// <param name="name">The name of the repository</param>
/// <param name="commit">The commit to create</param>
IObservable<Commit> Create(string owner, string name, NewCommit commit);

/// <summary>
/// Create a commit for a given repository
/// </summary>
Expand Down
4 changes: 2 additions & 2 deletions Octokit.Reactive/Clients/IObservableDeploymentsClient.cs
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ public interface IObservableDeploymentsClient
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
IObservable<Deployment> GetAll(string owner, string name);

/// <summary>
/// Gets all the deployments for the specified repository. Any user with pull access
/// to a repository can view deployments.
Expand All @@ -43,7 +43,7 @@ public interface IObservableDeploymentsClient
/// <param name="name">The name of the repository</param>
/// <param name="options">Options for changing the API response</param>
IObservable<Deployment> GetAll(string owner, string name, ApiOptions options);

/// <summary>
/// Gets all the deployments for the specified repository. Any user with pull access
/// to a repository can view deployments.
Expand Down
8 changes: 4 additions & 4 deletions Octokit.Reactive/Clients/IObservableEventsClient.cs
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ public interface IObservableEventsClient
/// </remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
IObservable<Activity> GetAllIssuesForRepository(string owner, string name);
IObservable<IssueEvent> GetAllIssuesForRepository(string owner, string name);

/// <summary>
/// Gets all the issue events for a given repository
Expand All @@ -85,7 +85,7 @@ public interface IObservableEventsClient
/// http://developer.github.com/v3/activity/events/#list-issue-events-for-a-repository
/// </remarks>
/// <param name="repositoryId">The Id of the repository</param>
IObservable<Activity> GetAllIssuesForRepository(long repositoryId);
IObservable<IssueEvent> GetAllIssuesForRepository(long repositoryId);

/// <summary>
/// Gets all the issue events for a given repository
Expand All @@ -96,7 +96,7 @@ public interface IObservableEventsClient
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="options">Options for changing the API response</param>
IObservable<Activity> GetAllIssuesForRepository(string owner, string name, ApiOptions options);
IObservable<IssueEvent> GetAllIssuesForRepository(string owner, string name, ApiOptions options);

/// <summary>
/// Gets all the issue events for a given repository
Expand All @@ -106,7 +106,7 @@ public interface IObservableEventsClient
/// </remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="options">Options for changing the API response</param>
IObservable<Activity> GetAllIssuesForRepository(long repositoryId, ApiOptions options);
IObservable<IssueEvent> GetAllIssuesForRepository(long repositoryId, ApiOptions options);

/// <summary>
/// Gets all the events for a given repository network
Expand Down
36 changes: 36 additions & 0 deletions Octokit.Reactive/Clients/IObservableIssueCommentsClient.cs
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,42 @@ public interface IObservableIssueCommentsClient
/// <param name="options">Options for changing the API response</param>
IObservable<IssueComment> GetAllForRepository(long repositoryId, ApiOptions options);

/// <summary>
/// Gets Issue Comments for a repository.
/// </summary>
/// <remarks>http://developer.github.com/v3/issues/comments/#list-comments-in-a-repository</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="request">The sorting <see cref="IssueCommentRequest">parameters</see></param>
IObservable<IssueComment> GetAllForRepository(string owner, string name, IssueCommentRequest request);

/// <summary>
/// Gets Issue Comments for a repository.
/// </summary>
/// <remarks>http://developer.github.com/v3/issues/comments/#list-comments-in-a-repository</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="request">The sorting <see cref="IssueCommentRequest">parameters</see></param>
IObservable<IssueComment> GetAllForRepository(long repositoryId, IssueCommentRequest request);

/// <summary>
/// Gets Issue Comments for a repository.
/// </summary>
/// <remarks>http://developer.github.com/v3/issues/comments/#list-comments-in-a-repository</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="request">The sorting <see cref="IssueCommentRequest">parameters</see></param>
/// <param name="options">Options for changing the API response</param>
IObservable<IssueComment> GetAllForRepository(string owner, string name, IssueCommentRequest request, ApiOptions options);

/// <summary>
/// Gets Issue Comments for a repository.
/// </summary>
/// <remarks>http://developer.github.com/v3/issues/comments/#list-comments-in-a-repository</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="request">The sorting <see cref="IssueCommentRequest">parameters</see></param>
/// <param name="options">Options for changing the API response</param>
IObservable<IssueComment> GetAllForRepository(long repositoryId, IssueCommentRequest request, ApiOptions options);

/// <summary>
/// Gets Issue Comments for a specified Issue.
/// </summary>
Expand Down
2 changes: 1 addition & 1 deletion Octokit.Reactive/Clients/IObservableIssueTimelineClient.cs
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ public interface IObservableIssueTimelineClient
/// <param name="number">The issue number</param>
/// <param name="options">Options for changing the API response</param>
IObservable<TimelineEventInfo> GetAllForIssue(string owner, string repo, int number, ApiOptions options);

/// <summary>
/// Gets all the various events that have occurred around an issue or pull request.
/// </summary>
Expand Down
2 changes: 1 addition & 1 deletion Octokit.Reactive/Clients/IObservableIssuesEventsClient.cs
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ public interface IObservableIssuesEventsClient
/// <param name="name">The name of the repository</param>
/// <param name="number">The issue number</param>
IObservable<EventInfo> GetAllForIssue(string owner, string name, int number);

/// <summary>
/// Gets all events for the issue.
/// </summary>
Expand Down
4 changes: 2 additions & 2 deletions Octokit.Reactive/Clients/IObservableMilestonesClient.cs
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ public interface IObservableMilestonesClient
[SuppressMessage("Microsoft.Naming", "CA1716:IdentifiersShouldNotMatchKeywords", MessageId = "Get",
Justification = "Method makes a network request")]
IObservable<Milestone> Get(string owner, string name, int number);

/// <summary>
/// Gets a single Milestone by number.
/// </summary>
Expand All @@ -44,7 +44,7 @@ public interface IObservableMilestonesClient
/// <param name="name">The name of the repository</param>
/// <returns></returns>
IObservable<Milestone> GetAllForRepository(string owner, string name);

/// <summary>
/// Gets all open milestones for the repository.
/// </summary>
Expand Down
30 changes: 30 additions & 0 deletions Octokit.Reactive/Clients/IObservableOrganizationsClient.cs
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ public interface IObservableOrganizationsClient
/// </summary>
/// <param name="user">The login for the user</param>
/// <returns></returns>
[Obsolete("Please use IObservableOrganizationsClient.GetAllForUser() instead. This method will be removed in a future version")]
IObservable<Organization> GetAll(string user);

/// <summary>
Expand All @@ -54,8 +55,37 @@ public interface IObservableOrganizationsClient
/// <param name="user">The login for the user</param>
/// <param name="options">Options for changing the API response</param>
/// <returns></returns>
[Obsolete("Please use IObservableOrganizationsClient.GetAllForUser() instead. This method will be removed in a future version")]
IObservable<Organization> GetAll(string user, ApiOptions options);

/// <summary>
/// Returns all the organizations for the specified user
/// </summary>
/// <param name="user">The login for the user</param>
/// <returns></returns>
IObservable<Organization> GetAllForUser(string user);

/// <summary>
/// Returns all the organizations for the specified user
/// </summary>
/// <param name="user">The login for the user</param>
/// <param name="options">Options for changing the API response</param>
/// <returns></returns>
IObservable<Organization> GetAllForUser(string user, ApiOptions options);

/// <summary>
/// Returns all the organizations
/// </summary>
/// <returns></returns>
IObservable<Organization> GetAll();

/// <summary>
/// Returns all the organizations
/// </summary>
/// <param name="request">Search parameters of the last organization seen</param>
/// <returns></returns>
IObservable<Organization> GetAll(OrganizationRequest request);

/// <summary>
/// Update the specified organization with data from <see cref="OrganizationUpdate"/>.
/// </summary>
Expand Down
8 changes: 7 additions & 1 deletion Octokit.Reactive/Clients/IObservablePullRequestsClient.cs
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,16 @@ namespace Octokit.Reactive
public interface IObservablePullRequestsClient
{
/// <summary>
/// Client for managing comments.
/// Client for managing review comments.
/// </summary>
[Obsolete("Please use IObservablePullRequestsClient.ReviewComment. This will be removed in a future version")]
IObservablePullRequestReviewCommentsClient Comment { get; }

/// <summary>
/// Client for managing review comments.
/// </summary>
IObservablePullRequestReviewCommentsClient ReviewComment { get; }

/// <summary>
/// Gets a single Pull Request by number.
/// </summary>
Expand Down
2 changes: 1 addition & 1 deletion Octokit.Reactive/Clients/IObservableReferencesClient.cs
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public interface IObservableReferencesClient
[SuppressMessage("Microsoft.Naming", "CA1716:IdentifiersShouldNotMatchKeywords", MessageId = "Get",
Justification = "Method makes a network request")]
IObservable<Reference> Get(string owner, string name, string reference);

/// <summary>
/// Gets a reference for a given repository by reference name
/// </summary>
Expand Down
2 changes: 1 addition & 1 deletion Octokit.Reactive/Clients/IObservableReleasesClient.cs
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ public interface IObservableReleasesClient
/// <param name="data">Description of the asset with its data</param>
/// <exception cref="ApiException">Thrown when a general API error occurs.</exception>
IObservable<ReleaseAsset> UploadAsset(Release release, ReleaseAssetUpload data);

/// <summary>
/// Gets the specified <see cref="ReleaseAsset"/> for the specified release of the specified repository.
/// </summary>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ public interface IObservableRepositoryContentsClient
/// </summary>
/// <param name="repositoryId">The Id of the repository</param>
IObservable<string> GetReadmeHtml(long repositoryId);

/// <summary>
/// Get an archive of a given repository's contents
/// </summary>
Expand Down Expand Up @@ -167,7 +167,7 @@ public interface IObservableRepositoryContentsClient
/// <param name="reference">The name of the commit/branch/tag. Default: the repository’s default branch (usually master)</param>
/// <param name="path">The content path</param>
IObservable<RepositoryContent> GetAllContentsByRef(long repositoryId, string reference, string path);

/// <summary>
/// Returns the contents of the home directory in a repository.
/// </summary>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ public interface IObservableRepositoryHooksClient
/// <param name="options">Options for changing the API response</param>
/// <remarks>See <a href="http://developer.github.com/v3/repos/hooks/#list">API documentation</a> for more information.</remarks>
IObservable<RepositoryHook> GetAll(string owner, string name, ApiOptions options);

/// <summary>
/// Gets the list of hooks defined for a repository
/// </summary>
Expand Down
Loading