This repository has been archived by the owner on May 7, 2018. It is now read-only.
Updating Octokit to the 0.24.0 #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release 0.23 - Thumbs Up
* Missing Milestone fields * Removing private Milestone field
Add missing `SecurityCritical` attribute
Correcting return type in ObservableEventsClient
[UserUpdate] - Fix typo.
* [RepositoriesClient] - Fix github deployments url. * [ReposirotiesClient] - Fix Collcaborators => Deployments in comments.
* Allow base64 direct content for create/update file * Add overload to avoid breaking change
* Update IOrganizationsClient.cs * Added the Uri for the organizations Renamed the existing organizations uri to userOrganizations and created a new organizations uri. * Implementation of the GetAllOrganizations * Interface modification for the GetAllOrganizations * Implementation of the GetAllOrganizations * Created the tests for the two new methods * remove new line * Reverted the changes i did to the ApiUrls class to be backward compatible. Created new client method and marked the old one [Obsolete] to be removed in a futur release. Created a new request class to support the since attribute. Updated the Unit Tests Updated all the csproj to have the proper references. * Renamed test * Deprecated the Organizations method to be replaced by the new UserOrganizations method. * Created 2 new test for the getAll method. Renamed the existing one to make it clear they test the user organization. * tweaks to integration tests
* obsolete comment and add ReviewComment * obsolete PullRequest.Comment and change to ReviewComment * update ObservablePullRequestClient and interface to use ReviewComment * fixed formatting issues have Comment return new ReviewComment
* Draft section on ApiInfo in getting started * typo: to --> do * Add link to github api * Add note on authenticated client limits * wording tweak * Point to better API doc link * change variable init in code sample
* Make GetAllForRepo to accept optional args * Fix tests * add missing interfaces * fix tests * Fix tests * fix tests * fix tests * fix tests * fix tests * fix tests * fix * fix tests * fix tests
* Update label docs to reflect color information Resolves octokit#790 * Clarify doc language Because I couldn't just have a one-commit PR. No, that'd be too easy. * Futher clarification I guess we might as well make it right.
introduce Code of Conduct
* [WIP] * add new method to add assignees for an issue * added new overloads * added unit tests * fixed missed overload calls * fixed inconsistency in tests * added integration tests * fixed errors in tests * fixed all remarks * added new overloads * added unit tests * added integration tests * fixed incorrect variable names * added new overloads * added unit tests * added itegration tests * fixed integration tests * removed extra empty lines * fixed errors in unit tests * added overloads on IObservableReleasesClient and IReleasesClient * added new unit tests * added integration tests * added Task as return value of unit tests * added Task as return parameter * added return value ReleasesClientTests * another try to get tests work * another one try * undo prev commit * fixed errors in tests * removed extra ThrowsAsync checks * added new overloads * added unit tests * added integration tests * added integration tests * Add ApiOptions overloads to IWatchedClient + tests. * Add ApiOptions overloads to IObservableWatchedClient + tests. * More tests. * fixed error in ObservableWatchedClient * added unit tests * added integration tests * added new overloads * added unit tests * added integration tests * renamed "Ensures" methods to deliver more consistency in code * fixed failed tests * Add ApiOptions overloads to methods on I(Observable)IssuesLabelsClient (octokit#1329) * correcting a couple of tests (octokit#1331) * Add ApiOption overloads to methods on I(Observable)OrganizationsClient (octokit#1324) * Add ApiOptions overloads to methods on I(Observable)OrganizationMembersClient (octokit#1332) * fix description * add new response for IssueAssignees * add constructor for IssueAssignees * add debugger display for NewAssignees * add methods for observable assignees client; new unit tests * add observable unit tests for add method * place AddAssignees under IssueClient * fix description * [WIP] add generic delete method * revert add assignees * add assignees key under issue client * remove IssueAssignees dependencies * fix type IssueAssignees * add remove method for issue assignees; finish generic delete method * unit tests for remove assignees * Add Assignees property to NewIssue and UpdateIssue requets Add Asignees property to Issue response Removed [SerializeNull] attribute from UpdateIssue.Assignee as this was causing it to remove assignee when none was specified Add a couple of integration tests to prove Assignees are being deserialised * rename NewAssignees to AssignessUpdate * change Assignees key description * check null Issue.ToUpdate method * add accept header for IssuesClientTests * Fix some more unit tests * add integration test Check if an assignee was added to an issue * fix merge conflicts * resolve conflicts * implement some hints from @ryangribble * resolve merge fixes * clean up * some more changes * create new repo Create a new repo for integrationtest 'CanRetrieveIssuesWithMultipleAssignees()' * fix merge * fix conflicts * fix xml * change test * change delete overloads * Fix tests * fix xml * Add helper function RemoveLabel * Add helper function RemoveAssignee * Format last commit * Add integration tests to exercise new Assignees field on IssueUpdate * GitHub API doesnt allow Assignee and Assignees properties to both be specified - API docs say that Assignee is deprecated so mark it [Obsolete] and dont populate it in Issue.ToUpdate() * Add Assignees field to PullRequest response object, and integration tests to verify it is populated. This field is not listed in the API docs but probing the API revealed it is included in payloads * add a couple of extra tests to verify the IssueUpdate.Labels is working correctly * Include assignees in ctor for consistency * fix IssueUpdate test for new Assignees field
* Add some tests to be completed * Actually fail the tests * Create AbuseException class Copied from ForbiddenException and then gone over to inherit from it. * Actually add AbuseException to csproj * Update test file * Ran .\build FixProjects * Test updates * Default message update for AbuseException * Separate the exception creation logic * Remove message assertion -- doesn't matter here * Additional test for abuse message * Remove unnecessary variable assignment * Failing test for unsafe request * Attempt to fix test Still broken -- I don't think empty strings count to trigger the default message * Remove test that will always fail due to another issue Opened octokit#1529 to explore this. * New tests (some failing) * Passing tests are, like, better than failing tests. * Last passing test * Cleanup * Add test for zero value and fix code Lol boundary cases. * cleanup * Mark ParseRetryAfterSeconds as static * Add GetObjectData override to AbuseException To include data for RetryAfterSeconds variable, and satisfy the build check. * Add back failing test & skip it * Change to nullable int with null default * Fix tests around nullable default * whitespace fixes * Compact the logic; tests still pass * Invert the if statements for compactness / clarity * Test subclasses & reformatting * Test name changes * Whitespace fix * Remove redundant line
* Adding missing review types to event info. * Fixing whitespace. * Reword `BaseRefChanged` comment
* add Id for PullRequest.cs added the Id property for PullRequest model * use long for pull request id * update comments for PullRequest.Id and Issue.Id make it more intuitive... a question, issue.Id and comment.Id are int type. do we have any concern on it? * plus the one for pullrequest forgot to check this change. * update the integration test for Id Property long will never be null
…Size (octokit#1473) * Add some missing fields to Repository object * Remove WatchersCount as due to historic reasons this is actually the starred count and not the watching count (which is in SubscribersCount). See octokit#699 for more info
…rings (octokit#1540) * return null if ApiError.Message is empty or whitespace * Uncomment test, which now passes
…unning the integration test "SearchForExcludedLanguage" (octokit#1541)
* Add release notes and bump version to 0.24 * run "build FormatCode" to fix up whitespace/formatting issues * Fix failing Ssh key tests due to "validation exception". This key must be in use on github (under another user, most likely from these tests failing). Changed to a new SSH key and tweaked tests to reduce chance of a key being created and not destroyed * Assignee and Assignees cant both be specified on NewIssue. We missed this one in the PR. Marked Assignee as [Obsolete] and fixed tests to use Assignees * Fix a couple of Reactions tests that were calling the wrong client methods * Fix timeline tests - looks like the response class has changed shape a bit, it now has an Issue object in the payload and Id field isnt present (leaving Id field there in case other timeline events do use it) * Fix some following tests that require the test user to follow more than 1 other user * Unskip these Event tests now because apparently they work! * add breaking changes notes * Update ApiErrorMessageSafe to return null for empty and whitespace strings (octokit#1540) * return null if ApiError.Message is empty or whitespace * Uncomment test, which now passes * update release notes to include PR1540 * Add "Bot" AccountType, was causing a deserialization exception when running the integration test "SearchForExcludedLanguage" (octokit#1541) * Update to include PR1541 * add bullets to make release notes easier to read * markup additional code mentions in notes * Fix grammar fields => field
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Grabbing the latest release and updating things. As of this merge, the only project file that should be changed when updating Octokit is
Octokit-35.csproj, by copying the file list fromOctokit-mono.csproj. Should make it easier to track changes this way.Before merging, this should be tested in GitHub for Unity.