Merge pull request #67 from brummett/db-full

Return 503 if the database server can't make the database

docs/rest-api.txt

@@ -128,6 +128,8 @@ Returns 201 and JSON in the body
 }
 The Location header will be the URL for this entity
 
+Returns 503 if the database server was not able to create the requested database
+
 -----------------------------------------------------
 
 POST /databases?based_on=<template-name>
@@ -149,6 +151,7 @@ Returns 201 and JSON in the body
 The Location header will be the URL for this entity
 
 Returns 404 if there is no template with that name
+Returns 503 if the database server was not able to create the requested database
 
 ---------------------------------------------------------
 

lib/TestDbServer/DatabaseRoutes.pm

@@ -167,6 +167,10 @@ sub create {
             $self->app->log->error('template not found');
             $return_code = 404;
 
+        } elsif (ref($_) && $_->isa('Exception::CannotCreateDatabase')) {
+            $self->app->log->error("Cannot create database: $_");
+            $return_code = 503;
+
         } else {
             $self->app->log->fatal("_create_database_from_template: $_");
             $return_code = 400;

t/commands.t

@@ -206,6 +206,25 @@ subtest 'create database from template' => sub {
             )->dropdb;
 };
 
+subtest 'failed create database throws exception' => sub {
+    plan tests => 1;
+
+    local *DBI::db::do = sub { die "Fake!" };
+
+    my $cmd = TestDbServer::Command::CreateDatabaseFromTemplate->new(
+                    owner => undef,
+                    host => $config->db_host,
+                    port => $config->db_port,
+                    template_name => $config->default_template_name,
+                    schema => $schema,
+                    superuser => $config->db_user,
+                );
+
+    throws_ok { $cmd->execute() }
+            'Exception::CannotCreateDatabase',
+            'Caught "CannotCreateDatabase" when create database dies';
+};
+
 subtest 'delete template' => sub {
     plan tests => 4;