Merge pull request #66 from brummett/delete-template

Allow deleting a template which has databases made from it
genome · Mar 17, 2015 · 44ac1aa · 44ac1aa
2 parents 8fd2ece + 3a449e7
commit 44ac1aa
Show file tree

Hide file tree

Showing 2 changed files with 49 additions and 1 deletion.
diff --git a/lib/TestDbServer/Command/DeleteTemplate.pm b/lib/TestDbServer/Command/DeleteTemplate.pm
@@ -12,6 +12,15 @@ sub _entity_find_method { 'find_template' }
 sub _entity_id_method { 'template_id' }
 sub _not_found_exception { 'Exception::TemplateNotFound' }
 
+sub execute {
+    my $self = shift;
+
+    my $databases_with_this_template = $self->schema->search_database(template_id => $self->template_id);
+    $databases_with_this_template->update({template_id => undef});
+
+    $self->SUPER::execute();
+}
+
 __PACKAGE__->meta->make_immutable;
 
 1;
diff --git a/t/commands.t b/t/commands.t
@@ -22,7 +22,7 @@ my $config = TestDbServer::Configuration->new_from_path();
 my $schema = create_new_schema($config);
 my $uuid_gen = Data::UUID->new();
 
-plan tests => 7;
+plan tests => 8;
 
 subtest 'create template from database' => sub {
     plan tests => 5;
@@ -231,6 +231,45 @@ subtest 'delete template' => sub {
     ok(! _connect_to_database($pg->name, $pg->owner), 'cannot connect to deleted template database');
 };
 
+subtest 'delete template with databases' => sub {
+    plan tests => 7;
+
+    my $pg = new_pg_instance();
+
+    my $template = $schema->create_template(
+                                name => $pg->name,
+                                owner => $pg->owner,
+                            );
+    ok($template, 'create template');
+
+    my $create_db_command = TestDbServer::Command::CreateDatabaseFromTemplate->new(
+                    owner => undef,
+                    host => $config->db_host,
+                    port => $config->db_port,
+                    template_name => $template->name,
+                    schema => $schema,
+                    superuser => $config->db_user,
+                );
+    my $database = $create_db_command->execute();
+    ok($database, 'create db from template');
+
+    my $delete_tmpl_command = TestDbServer::Command::DeleteTemplate->new(
+                template_id => $template->template_id,
+                schema => $schema,
+                host => $config->db_host,
+                port => $config->db_port,
+                superuser => $config->db_user);
+    ok($delete_tmpl_command->execute(), 'delete template');
+
+    ok(! _connect_to_database($template->name, $template->owner), 'cannot connect to deleted template database');
+    ok( _connect_to_database($database->name, $database->owner), 'can connect to derived database');
+
+    my $template_record = $schema->find_template($template->template_id);
+    ok(! $template_record, 'template record was deleted');
+    my $database_record = $schema->find_database($database->database_id);
+    is($database_record->template_id, undef, q(database record's template_id is now null));
+};
+
 subtest 'delete database' => sub {
     plan tests => 5;