Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dashboard #2023

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remove dashboard #2023

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c36762
commit dashboard in wet template
Steph4104 Jul 2, 2019
304ab56
keep unregister_page
Steph4104 Jul 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions mod/wet4/start.php
100644 → 100755
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,8 @@ function wet4_theme_init()

//register a page handler for friends
elgg_unregister_page_handler('friends'); //unregister core page handler
elgg_unregister_page_handler('dashboard'); //unregister dashboard handler to make our own
elgg_register_page_handler('dashboard', 'wet4_dashboard_page_handler');
//elgg_unregister_page_handler('dashboard'); //unregister dashboard handler to make our own
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't you want to keep the other one unregistered as well as not registering the wet4 one?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we can

//elgg_register_page_handler('dashboard', 'wet4_dashboard_page_handler');
elgg_register_page_handler('friends', '_wet4_friends_page_handler'); //register new page handler for data tables
elgg_register_page_handler('friendsof', '_wet4_friends_page_handler');
elgg_register_page_handler('activity', 'activity_page_handler');
Expand Down