Remove dashboard #2023
Open
Remove dashboard #2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Phanoix
reviewed
Jul 4, 2019
mod/wet4/start.php
Outdated
| @@ -78,8 +78,8 @@ function wet4_theme_init() | |||
|
|
|||
| //register a page handler for friends | |||
| elgg_unregister_page_handler('friends'); //unregister core page handler | |||
| elgg_unregister_page_handler('dashboard'); //unregister dashboard handler to make our own | |||
| elgg_register_page_handler('dashboard', 'wet4_dashboard_page_handler'); | |||
| //elgg_unregister_page_handler('dashboard'); //unregister dashboard handler to make our own | |||
There was a problem hiding this comment.
Wouldn't you want to keep the other one unregistered as well as not registering the wet4 one?
Phanoix
approved these changes
Jul 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://zube.io/tbs-sct/gctools/c/4964
To remove dashboard, you can only turn off the plugin in the admin setting( plugins -> User Dashboard 1.9)
This will remove the option in the menu to access it. But, if an user as dashboard in his bookmarks or know the URL, he still can access it.
This pull request is to remove the possibility to access the dashboard by URL.
Before merge this pull request, need to delete what add in comment and remove the function linked to "wet4_dashboard_page_handler"