Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix talents order in gcsim button #1493

Merged
merged 1 commit into from
Feb 11, 2024
Merged

fix talents order in gcsim button #1493

merged 1 commit into from
Feb 11, 2024

Conversation

clevernt
Copy link
Contributor

@clevernt clevernt commented Feb 11, 2024 •
edited by nguyentvan7
Loading

Describe your changes

  • Rearranges talents order when exporting to gcsim in order to match gcsim's ordering

Issue or discord link

Testing/validation

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

  • I have commented my code in hard-to understand areas.
  • I have made corresponding changes to README or wiki.
  • For front-end changes, I have updated the corresponding English translations.
  • I have run yarn run mini-ci locally to validate format and lint.
  • If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

@frzyc frzyc merged commit c4356ce into frzyc:master Feb 11, 2024
5 checks passed
@clevernt clevernt deleted the talents-order branch May 18, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nguyentvan7 nguyentvan7 nguyentvan7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exporting to gcsim rearranges talents
3 participants
@clevernt @nguyentvan7 @frzyc