revert: re-enable workspaces #278
Conversation
blaggacao
force-pushed
the
revert/re-enable-workspaces
branch
2 times, most recently
from
f36cc1c to
9a7b551
Compare
5 failed tests on run #248 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Discussion > all discussion actions |
Screenshots
Video
|
|
onboarding.cy.js • 1 failed test
| Test | Artifacts | |
|---|---|---|
| Onboarding > onboarding works |
Screenshots
Video
|
|
project.cy.js • 1 failed test
| Test | Artifacts | |
|---|---|---|
| Project > project creation, move to team and archive |
Screenshots
Video
|
|
team.cy.js • 1 failed test
| Test | Artifacts | |
|---|---|---|
| Team > team creation, readme edit and archive |
Screenshots
Video
|
|
Review all test suite changes for PR #278 ↗︎
blaggacao
force-pushed
the
revert/re-enable-workspaces
branch
from
9a7b551 to
511fe16
Compare
|
@netchampfaris I removed the |
|
@netchampfaris Could this be reconsidered? It's kind of a particular interest requirement, but given that the other new style apps use workspaces (afaik: Crm, Builder & Insights) there might be an independent value on aligning the code layout between projects. As a collateral it would really help me package GamePlan properly for Frappix. 😄 |
|
ping |
blaggacao
force-pushed
the
revert/re-enable-workspaces
branch
2 times, most recently
from
0ff6746 to
81649f6
Compare
blaggacao
force-pushed
the
revert/re-enable-workspaces
branch
from
81649f6 to
6411b36
Compare
blaggacao
force-pushed
the
revert/re-enable-workspaces
branch
from
6411b36 to
34d4b8c
Compare
|
@netchampfaris Could you please verify if 41b5936 is also an independent fix? Thank you! |
|
Hey, workspaces is only meant for development. I have no idea what is "Frappix", but Gameplan's frontend assets should build just fine without workspaces since it will download frappe-ui from npm based on the package.json. |
Expand/collapse bug is fixed 632a355 |
|
Hey https://github.com/blaggacao/frappix uses a sandboxed build. I don't remember, what exactly failed, but if the build itself (not fetching pinned! resources) requires network access, then that's a big red flag, already. Ever since it failed, I started carrying this patch. I'll have to find time to rebase and re-invigorate the claim. The gameplan packaging recipe is here: https://github.com/blaggacao/frappix/blob/main/src%2Foverlays%2Ffrappe%2Fgameplan%2Fdefault.nix — need to check with the latest developments. |
|
Ah, I think I remember the problem: This file is empty https://github.com/frappe/gameplan/blob/main/yarn.lock but at the same time this is the level there all other apps pin their dependencies. I'd have to check if there's a way to package the individual components in isolation, but are they properly declaring dependencies between each other? |
|
This is the correct https://github.com/frappe/gameplan/blob/main/frontend/yarn.lock file with pinned dependencies. |
|
Thanks, yea I'll try to make it work that way. |
|
Ok, I just hit this again, logged it for now: blaggacao/frappix#18 (comment) If there's no way that regular workspaces may be used, I need to figure out another way or leave gameplan un-supported for the time being. |
f9c8db3
The original "chore" commit didn't specify a specific reason.
On the other hand, the lack of a proper workspace configuration breaks the Frappix build of Gameplan.
This PR re-instates the workspaces and heals Frappix builds of Gameplan