Frappe apps incompatibilities

[blaggacao]

• Builder broke the build in: frappe/builder@cae39ff#commitcomment-148362353
  • Relative import requires a bench layout in the environment - bad practice frappe/builder#305
• Crm broke the build in frappe/crm@a439433#commitcomment-148363342
  • Relative import requires a bench layout in the environment - bad practice frappe/crm#555
• Drive waiting on update on build: remove drive patches #11
• HRMS broke build with Build broake due to missing dep declaration in lockfile frappe/hrms#2342
• Webshop: chore: use flit-core build as other frappe apps (#99) frappe/webshop#211
• Gameplan: Frappe apps incompatibilities #18 (comment) (below)
  • revert: re-enable workspaces frappe/gameplan#278
• Insights: upstream nix issue with submodules, see below

Originally posted by @blaggacao in #16 (comment)

[blaggacao]

❯ nix log /nix/store/yshagx10g0bllrbgx7d6cnarp9sl6ipw-gameplan_-20241218.115224.drv 
Running phase: unpackPhase
@nix { "action": "setPhase", "phase": "unpackPhase" }
unpacking source archive /nix/store/wj8dpqhdjqqk1km2mdaanxhlhgs5g5kq-gameplan-prod
source root is gameplan-prod
Running phase: patchPhase
@nix { "action": "setPhase", "phase": "patchPhase" }
Running phase: updateAutotoolsGnuConfigScriptsPhase
@nix { "action": "setPhase", "phase": "updateAutotoolsGnuConfigScriptsPhase" }
Running phase: configurePhase
@nix { "action": "setPhase", "phase": "configurePhase" }
Running phase: buildPhase
@nix { "action": "setPhase", "phase": "buildPhase" }
yarn config v1.22.22
success Set "yarn-offline-mirror" to "/nix/store/5bq3n161480ii3y3xwh3fian2l5pmdgx-offline".
Done in 0.04s.
yarn install v1.22.22
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...
[4/4] Building fresh packages...
warning Ignored scripts due to flag.
Done in 0.06s.
patching script interpreter paths in .
./frappe-ui/.husky/pre-commit: interpreter directive changed from "#!/bin/sh" to "/nix/store/gwgqdl0242ymlikq9s9s62gkp5cvyal3-bash-5.2p37/bin/sh"
yarn run v1.22.22
$ cd frontend && yarn build
warning You don't appear to have an internet connection. Try the --offline flag to use the cache for registry queries.
warning package.json: No license field
$ vite build --base=/assets/gameplan/frontend/ && yarn copy-html-entry
/bin/sh: vite: not found
error Command failed with exit code 127.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 127.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

This is likely due to gameplan not using workspaces and nix' yarn tooling not being able to recurse into the sub-folders to discover pinned dependencies.

As a consequence, vite - which is pinned inside the frontend/yarn.lock - won't be available in the environment.

[blaggacao]

❯ std //apps/sources/insights:fetch
Finished at 20:10:22 after 0s
[I 01-28 20:10:23.251 core:533] insights: updated from v2.2.6 to v3.0.14 taskName=Task-2 url=https://github.com/frappe/insights/releases/tag/v3.0.14
[I 01-28 20:10:23.260 core:272] insights: update nix taskName=None file=/home/dar/src/github.com/blaggacao/frappix/apps/sources/insights.nix
[E 01-28 20:10:25.672 core:245] Locking the source in nix failed; stderr from the nix command: 
    error:
           … while calling the 'removeAttrs' builtin
             at «string»:1:1:
                1| builtins.removeAttrs (builtins.fetchTree {type = "git"; url = "[email protected]:frappe/insights.git"; submodules = true; rev = "99902fc7cc3e8194e9ee1de912431327a870f397"; allRefs = true;}) ["outPath"]
                 | ^
    
           … while calling the 'fetchTree' builtin
             at «string»:1:23:
                1| builtins.removeAttrs (builtins.fetchTree {type = "git"; url = "[email protected]:frappe/insights.git"; submodules = true; rev = "99902fc7cc3e8194e9ee1de912431327a870f397"; allRefs = true;}) ["outPath"]
                 |                       ^
    
           (stack trace truncated; use '--show-trace' to show the full, detailed trace)
    
           error: Cannot find Git revision '03115629ffdb3712accd57123fb1d6b882a15e67' in ref 'refs/heads/main' of repository 'https://github.com/nextchamp-saqib/frappe-ui.git'! Please make sure that the rev exists on the ref you've specified or add allRefs = true; to fetchGit.
     taskName=None type=git ref=refs/tags/v3.0.14 rev=99902fc7cc3e8194e9ee1de912431327a870f397

This looks like an actual bug in fetchTree.