-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DWS/shell: potentially exchange use of eventlog for static rabbitmapping file #244
Comments
@grondo do you have any thoughts on this / whether it sounds like a good idea? |
Sounds like a pretty good idea to me. I'm guessing the mapping from compute node to rabbits will never change, so putting the redundant and duplicate information in the job eventlog may be wasting KVS space. I like the idea of setting the environment variable in the shell plugin using this new config file. Then users won't see a difference when you update to the new method. I can't think of a good reason to keep the mapping in the eventlog either. Unless that is the only way a job can see the rabbits to which it has access? |
Problem: the dws_environment shell plugin no longer looks for a mapping from rabbits to compute nodes in the 'dws_environment' eventlog entry, so that part of the event's context (which could be quite large) can be dropped. Drop it. Fixes flux-framework#244.
Problem: the dws_environment shell plugin no longer looks for a mapping from rabbits to compute nodes in the 'dws_environment' eventlog entry, so that part of the event's context (which could be quite large) can be dropped. Drop it. Fixes flux-framework#244.
Soon, all LC rabbit clusters will have a JSON file,
/etc/flux/system/rabbitmapping
, that maps compute nodes to rabbits and vice versa, structured like the following:It duplicates some information set in the eventlog for the
dws-environment
shell plugin, which reads events like(note that the eventlog entry provides a
rabbit: hostlist
mapping for every rabbit associated with the job)to figure out what the local rabbit is and set the
FLUX_LOCAL_RABBIT
environment variable. But if users can get the same information by runningjq .computes.$HOSTNAME /etc/flux/system/rabbitmapping
, I wonder if$FLUX_LOCAL_RABBIT
is necessary. Or, alternatively, perhaps the shell plugin could read from the file to set the variable, and the eventlog could drop that (potentially very large) entry.The text was updated successfully, but these errors were encountered: