Skip to content

Commit

Permalink
dws: drop rabbit mapping from eventlog context
Browse files Browse the repository at this point in the history
Problem: the dws_environment shell plugin no longer looks for a
mapping from rabbits to compute nodes in the 'dws_environment'
eventlog entry, so that part of the event's context (which could
be quite large) can be dropped.

Drop it.

Fixes flux-framework#244.
  • Loading branch information
jameshcorbett committed Jan 24, 2025
1 parent 4b8480c commit 97f79bc
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 8 deletions.
8 changes: 3 additions & 5 deletions src/job-manager/plugins/dws-jobtap.c
Original file line number Diff line number Diff line change
Expand Up @@ -687,11 +687,11 @@ static void prolog_remove_msg_cb (flux_t *h,
{
flux_plugin_t *p = (flux_plugin_t *)arg;
json_int_t jobid;
json_t *env = NULL, *rabbit_mapping = NULL;
json_t *env = NULL;
int *prolog_active, junk_prolog_active = 1;
int copy_offload = 0;

if (flux_msg_unpack (msg, "{s:I, s:o, s:o}", "id", &jobid, "variables", &env, "rabbits", &rabbit_mapping) < 0) {
if (flux_msg_unpack (msg, "{s:I, s:o}", "id", &jobid, "variables", &env) < 0) {
flux_log_error (h, "received malformed dws.prolog-remove RPC");
return;
}
Expand All @@ -712,11 +712,9 @@ static void prolog_remove_msg_cb (flux_t *h,
if (flux_jobtap_event_post_pack (p,
jobid,
"dws_environment",
"{s:O, s:O, s:b}",
"{s:O, s:b}",
"variables",
env,
"rabbits",
rabbit_mapping,
"copy_offload",
copy_offload)
< 0
Expand Down
3 changes: 0 additions & 3 deletions src/modules/coral2_dws.py
Original file line number Diff line number Diff line change
Expand Up @@ -524,9 +524,6 @@ def _workflow_state_change_cb_inner(workflow, winfo, handle, k8s_api, disable_fl
payload={
"id": jobid,
"variables": workflow["status"].get("env", {}),
"rabbits": {
rabbit: _RABBITS_TO_HOSTLISTS[rabbit] for rabbit in rabbits
},
},
).then(log_rpc_response)
save_elapsed_time_to_kvs(handle, jobid, workflow)
Expand Down

0 comments on commit 97f79bc

Please sign in to comment.