dws: drop rabbits from dws_environment eventlog entry context #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: currently, the dws-environment shell plugin sets a FLUX_LOCAL_RABBIT environment variable based on information saved in the eventlog. However, there could be a more flexible command-line tool that returns arbitrary compute-rabbit mapping information. Add a tool that does that.
Problem: there are no tests for the 'flux getrabbit' utility. Add tests.
Problem: dws2jgf expects a path to the rabbitmapping file, but that path is now expected to be found in the config. Make passing the path on the command line optional, and fall back to the config if not provided.
Problem: the `flux rabbitmapping` utility makes the FLUX_LOCAL_RABBIT environment variable obsolete. Drop it.
Problem: the dws_environment shell plugin no longer looks for a mapping from rabbits to compute nodes in the 'dws_environment' eventlog entry, so that part of the event's context (which could be quite large) can be dropped. Drop it. Fixes flux-framework#244.
Problem: the 'rabbits' entry in the 'dws_environment' eventlog entry has been removed, but tests still expect it. Remove tests for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: currently, the dws-environment shell plugin sets a
FLUX_LOCAL_RABBIT environment variable based on information saved
in the eventlog. However, there could be a more flexible command-line
tool that returns arbitrary compute-rabbit mapping information.
Add a tool that does that, and drop the FLUX_LOCAL_RABBIT env var.
Fixes #244 .