-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create basic performance measurement interface and integrate Caliper #51
Closed
ilumsden
wants to merge
22
commits into
flux-framework:main
from
TauferLab:caliper_integration_benchmark
Closed
Create basic performance measurement interface and integrate Caliper #51
ilumsden
wants to merge
22
commits into
flux-framework:main
from
TauferLab:caliper_integration_benchmark
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilumsden
force-pushed
the
caliper_integration_benchmark
branch
from
November 23, 2023 02:06
43800bf
to
4aaf093
Compare
ilumsden
force-pushed
the
caliper_integration_benchmark
branch
3 times, most recently
from
December 13, 2023 15:27
4fe3643
to
11d5eef
Compare
1. Removed dyad_code from public headers 2. used PROJECT_NAME variable for all code 3. prefixed PROJECT_NAME for util code to avoid conflicts
ilumsden
force-pushed
the
caliper_integration_benchmark
branch
3 times, most recently
from
December 18, 2023 21:38
464af40
to
6f02b9e
Compare
ilumsden
force-pushed
the
caliper_integration_benchmark
branch
from
December 18, 2023 21:41
6f02b9e
to
08abc06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does three things. First, it creates a super basic interface for working with annotation-based performance measurement tools. This interface simply consists of two macros
DYAD_PERF_REGION_BEGIN
andDYAD_PERF_REGION_END
. Second, this PR adds instances of these macros throughout the DTL and DYAD's core library. Finally, this PR adds an implementation of this interface for Caliper. This Caliper integration has been tested with the workflow I/O benchmark we are developing.