New Caliper Integration #80
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can confirm that I am getting Caliper files when running the workflow benchmark with these annotations enabled. I still need to verify that the CCTs I get when loading the data into Thicket look right. Once I've verified that, task 2 in the original comment on this PR will be done. |
|
Also, I will switch this PR to ready for review after I know the CCTs are good. Task 3 in the original PR comment can be done later if we want to. |
ilumsden
force-pushed
the
rma_caliper_integration
branch
2 times, most recently
from
2602f07 to
90b51f6
Compare
|
Todos:
|
ilumsden
force-pushed
the
rma_caliper_integration
branch
from
90b51f6 to
020bd29
Compare
…the C update annotations
…on't work for the time being
|
@hariharan-devarajan @JaeseungYeom this PR is ready for review |
…trings for region names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR usurps #51 for adding Caliper annotations to DYAD.
It builds on the recent code in
dyad_profiler.hinstead of building a separate library for performance annotations.This is currently a work-in-progress PR. The remaining things to be done before it is ready for merge are: