-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added CI for testing DYAD #47
Conversation
7959e16
to
97e3b99
Compare
bd293f3
to
794baf3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks good. However, in the future, we should look into the Spack GitHub Action to automate some of this Spack stuff.
@ilumsden Hey i am having some trouble running the CI with latest changes of the dev. Can u help me with this. When I run this locally I get
|
Reading small 4KB chunks are very slow so replacing it by reading all data into user buffer directly.
f9b2b28
to
d73b6ba
Compare
d73b6ba
to
f8d6b19
Compare
9ed5fd2
to
fded38f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First of all, it is great to hear that the test worked with UCX. Congratulation!
- We may need a better directory name than 'workflows' something that indicates this is for CI collection.
- We better think about the directory structure that is future proof
- Let's think about which tests are needed, and how we would structure them
- There are some files ending with some sort of control character like dash in a circle. I am not sure what this is.
50025e6
to
32e00b7
Compare
32e00b7
to
308ec59
Compare
No description provided.