Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added CI for testing DYAD #47

Merged
merged 4 commits into from
Oct 24, 2023
Merged

added CI for testing DYAD #47

merged 4 commits into from
Oct 24, 2023

Conversation

hariharan-devarajan
Copy link
Collaborator

No description provided.

@hariharan-devarajan hariharan-devarajan force-pushed the bugfix/ci-test branch 30 times, most recently from 7959e16 to 97e3b99 Compare September 20, 2023 16:12
@hariharan-devarajan hariharan-devarajan force-pushed the bugfix/ci-test branch 13 times, most recently from bd293f3 to 794baf3 Compare September 20, 2023 21:26
Copy link
Collaborator

@ilumsden ilumsden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good. However, in the future, we should look into the Spack GitHub Action to automate some of this Spack stuff.

@hariharan-devarajan
Copy link
Collaborator Author

@ilumsden Hey i am having some trouble running the CI with latest changes of the dev. Can u help me with this.

When I run this locally I get

Oct 18 14:46:17.815906 cpp_cons.err[0]: Could not allocate space for file buffer: Cannot allocate memory
Oct 18 14:46:17.815937 cpp_cons.err[0]: Cannot receive data from producer module
Oct 18 14:46:17.815941 cpp_cons.err[0]: : Cannot allocate memory
Oct 18 14:46:17.815965 cpp_cons.err[0]: dyad_pull failed!
Oct 18 14:46:17.815968 cpp_cons.err[0]: : No data available
Oct 18 14:46:17.821013 cpp_cons.err[0]: Could not allocate space for file buffer: Cannot allocate memory
Oct 18 14:46:17.821041 cpp_cons.err[0]: Cannot receive data from producer module
Oct 18 14:46:17.821045 cpp_cons.err[0]: : Cannot allocate memory
Oct 18 14:46:17.821197 cpp_cons.err[0]: dyad_pull failed!
Oct 18 14:46:17.821205 cpp_cons.err[0]: : No data available
Oct 18 14:46:17.824917 cpp_cons.err[0]: Could not allocate space for file buffer: Cannot allocate memory
Oct 18 14:46:17.824943 cpp_cons.err[0]: Cannot receive data from producer module
Oct 18 14:46:17.824945 cpp_cons.err[0]: : Cannot allocate memory
Oct 18 14:46:17.825103 cpp_cons.err[0]: dyad_pull failed!
Oct 18 14:46:17.825110 cpp_cons.err[0]: : No data available
Oct 18 14:46:17.828826 cpp_cons.err[0]: Could not allocate space for file buffer: Cannot allocate memory
Oct 18 14:46:17.828857 cpp_cons.err[0]: Cannot receive data from producer module
Oct 18 14:46:17.828861 cpp_cons.err[0]: : Cannot allocate memory
Oct 18 14:46:17.828884 cpp_cons.err[0]: dyad_pull failed!
Oct 18 14:46:17.828886 cpp_cons.err[0]: : No data available
Oct 18 14:46:17.833120 cpp_cons.err[0]: Could not allocate space for file buffer: Cannot allocate memory
Oct 18 14:46:17.833151 cpp_cons.err[0]: Cannot receive data from producer module
Oct 18 14:46:17.833154 cpp_cons.err[0]: : Cannot allocate memory
Oct 18 14:46:17.833178 cpp_cons.err[0]: dyad_pull failed!
Oct 18 14:46:17.833181 cpp_cons.err[0]: : No data ava

Reading small 4KB chunks are very slow so replacing it by reading all data into user buffer directly.
@hariharan-devarajan hariharan-devarajan force-pushed the bugfix/ci-test branch 3 times, most recently from f9b2b28 to d73b6ba Compare October 19, 2023 19:28
Copy link
Contributor

@JaeseungYeom JaeseungYeom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all, it is great to hear that the test worked with UCX. Congratulation!

  • We may need a better directory name than 'workflows' something that indicates this is for CI collection.
  • We better think about the directory structure that is future proof
  • Let's think about which tests are needed, and how we would structure them
  • There are some files ending with some sort of control character like dash in a circle. I am not sure what this is.

@JaeseungYeom JaeseungYeom merged commit 55aa4fa into main Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants