-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotfix: various build system fixes to support CI #52
Hotfix: various build system fixes to support CI #52
Conversation
Also, fix configure.ac
|
Also can u merge it with the CI PR to see if its fixed and do any other changes required for that. |
529db8e
to
5d7ab91
Compare
The scope of this PR has slightly changed. Now, it is a hotfix PR to address any build system bug that we encounter while testing #47. |
5d7ab91
to
e86723a
Compare
I will wait on the update for making sure to free dtl_handle in the finalization |
@JaeseungYeom I've fixed the freeing of the DTL handle in |
…ot be freed in some cases
871291b
to
6890cd9
Compare
#49 made UCX an optional dependency. However, it did not make the UCX-based code in
dyad_dtl_init
anddyad_dtl_finalize
conditionally compiled. As a result, if a user built DYAD without--enable-ucx
and then set the DTL mode toUCX
, failures would occur due todyad_dtl_init
anddyad_dtl_finalize
trying to call the corresponding UCX DTL functions, which would not have been built.This hotfix PR fixes this small, but important, bug.