Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Twitter (X) icon #74666

Closed
wants to merge 2 commits into from
Closed

Updated Twitter (X) icon #74666

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7dacb40
Updated Twitter (X) icon
blindaks Oct 7, 2023
fd2697c
Update X icon
blindaks Oct 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/auto-pr-merge.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ jobs:
// social logo
const repo_logo = "https://avatars0.githubusercontent.com/u/65761570?s=88&u=640f39b808c75c6b86460aa907dd030bcca2f3c7&v=4"
const slack_logo = "https://edent.github.io/SuperTinyIcons/images/svg/slack.svg"
const twitter_logo = "https://edent.github.io/SuperTinyIcons/images/svg/twitter.svg"
const twitter_logo = "https://fontawesome.com/icons/x-twitter?f=brands&s=solid&pc=%23ffffff"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link you added is not an icon, but a webpage that shows the icon. We need an icon that is a media file, like this one.

For example, compare these two links:

Do you see the difference? The first one is a webpage and the second one is a media file. We need a media file.

The link we are using for the icon is from SuperTinyIcons and there is a PR pending and ready to merge:

We can update the link once that PR gets merged, as it follows the guidelines for the resolution and aspect of the media. Otherwise, linking an SVG from another website could break the layout of the content.

Thanks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for explaining.

const fb_logo = "https://edent.github.io/SuperTinyIcons/images/svg/facebook.svg"
const reddit_logo = "https://edent.github.io/SuperTinyIcons/images/svg/reddit.svg"
const linkedin_logo = "https://edent.github.io/SuperTinyIcons/images/svg/linkedin.svg";
Expand Down