Updated Twitter (X) icon #74666
Updated Twitter (X) icon #74666
Conversation
|
@Esh07 Please review this PR. |
.github/workflows/auto-pr-merge.yml
Outdated
| @@ -105,7 +105,7 @@ jobs: | |||
| // social logo | |||
| const repo_logo = "https://avatars0.githubusercontent.com/u/65761570?s=88&u=640f39b808c75c6b86460aa907dd030bcca2f3c7&v=4" | |||
| const slack_logo = "https://edent.github.io/SuperTinyIcons/images/svg/slack.svg" | |||
| const twitter_logo = "https://edent.github.io/SuperTinyIcons/images/svg/twitter.svg" | |||
| const twitter_logo = "https://fontawesome.com/icons/x-twitter?f=brands&s=solid&pc=%23ffffff" | |||
There was a problem hiding this comment.
The link you added is not an icon, but a webpage that shows the icon. We need an icon that is a media file, like this one.
For example, compare these two links:
- The link you added: Font Awesome x-twitter icon
- The link we need: SuperTinyIcons twitter icon
Do you see the difference? The first one is a webpage and the second one is a media file. We need a media file.
The link we are using for the icon is from SuperTinyIcons and there is a PR pending and ready to merge:
We can update the link once that PR gets merged, as it follows the guidelines for the resolution and aspect of the media. Otherwise, linking an SVG from another website could break the layout of the content.
Thanks
There was a problem hiding this comment.
Thank you for explaining.
|
@Esh07 @tmsagarofficial Please merge this PR |
|
Hi @blindaks, Apologies for the delay. The repository has limited people with write access, so it might take some time for your PR to get merged. Once the maintainers are free and have time to go through the PRs, yours will be reviewed and merged. Happy coding! |
Closes #74494