-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable java 17 for testing project #903
Changes from 4 commits
0b8c15d
122a867
b8c33a6
bdce086
a53b69f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,83 @@ | ||
<?xml version="1.0" encoding="UTF-8"?> | ||
<project xmlns="http://maven.apache.org/POM/4.0.0" | ||
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> | ||
<modelVersion>4.0.0</modelVersion> | ||
<parent> | ||
<groupId>com.regnosys.rosetta</groupId> | ||
<artifactId>com.regnosys.rosetta.parent</artifactId> | ||
<version>0.0.0.main-SNAPSHOT</version> | ||
</parent> | ||
|
||
<name>Rosetta DSL Integration Test Project</name> | ||
<artifactId>rosetta-integration-tests</artifactId> | ||
<properties> | ||
<maven.compiler.release>17</maven.compiler.release> | ||
</properties> | ||
|
||
<dependencies> | ||
<!-- Inter-project dependencies --> | ||
<dependency> | ||
<groupId>com.regnosys.rosetta</groupId> | ||
<artifactId>com.regnosys.rosetta</artifactId> | ||
<version>${project.version}</version> | ||
</dependency> | ||
|
||
<dependency> | ||
<groupId>com.regnosys.rosetta</groupId> | ||
<artifactId>com.regnosys.rosetta.tests</artifactId> | ||
<version>${project.version}</version> | ||
</dependency> | ||
|
||
|
||
<!-- External dependencies --> | ||
<dependency> | ||
<groupId>org.eclipse.xtext</groupId> | ||
<artifactId>org.eclipse.xtext.testing</artifactId> | ||
</dependency> | ||
<dependency> | ||
<groupId>org.eclipse.xtext</groupId> | ||
<artifactId>org.eclipse.xtext.xbase.testing</artifactId> | ||
</dependency> | ||
<dependency> | ||
<groupId>org.junit.jupiter</groupId> | ||
<artifactId>junit-jupiter</artifactId> | ||
</dependency> | ||
<dependency> | ||
<groupId>org.mdkt.compiler</groupId> | ||
<artifactId>InMemoryJavaCompiler</artifactId> | ||
</dependency> | ||
|
||
<!-- Test dependencies --> | ||
<dependency> | ||
<groupId>org.mockito</groupId> | ||
<artifactId>mockito-core</artifactId> | ||
<scope>test</scope> | ||
</dependency> | ||
</dependencies> | ||
|
||
<build> | ||
<plugins> | ||
<plugin> | ||
<groupId>org.eclipse.xtend</groupId> | ||
<artifactId>xtend-maven-plugin</artifactId> | ||
</plugin> | ||
<plugin> | ||
<groupId>org.apache.maven.plugins</groupId> | ||
<artifactId>maven-clean-plugin</artifactId> | ||
<configuration> | ||
<filesets combine.children="append"> | ||
<fileset> | ||
<directory>${basedir}/xtend-gen</directory> | ||
<includes> | ||
<include>**/*</include> | ||
</includes> | ||
</fileset> | ||
</filesets> | ||
</configuration> | ||
</plugin> | ||
</plugins> | ||
</build> | ||
|
||
|
||
</project> |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
package com.regnosys.rosetta; | ||
|
||
public class Main { | ||
public static void main(String[] args) { | ||
System.out.println("Hello, World!"); | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -31,10 +31,10 @@ Workflow { | |
} | ||
runtimeTest = { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this should actually refer to the test utility project. It's where Xtext will generate it's test utilities. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. When the MWE2 runtimeTest points to
When I just moved the all the tests to integration testing - it started to generate point 1 which caused a unit test failure. When I move the MWE2 runtimeTest to point to I made a change to just disable the runtime test automation. The automation is meant to be a starting point and does not really (I think) provide much value any more. The other option is that we move the MWE2 runtimeTest back to There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sounds good! |
||
enabled = true | ||
name = "rosetta-testing" | ||
root = "${parentDir}/rosetta-testing" | ||
src = "${parentDir}/rosetta-testing/src/test/java" | ||
srcGen = "${parentDir}/rosetta-testing/src-gen/main/java" | ||
name = "rosetta-integration-tests" | ||
root = "${parentDir}/rosetta-integration-tests" | ||
src = "${parentDir}/rosetta-integration-tests/src/test/java" | ||
srcGen = "${parentDir}/rosetta-integration-tests/src-gen/main/java" | ||
} | ||
genericIde = { | ||
enabled = true | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems unnecessary?