enable java 17 for testing project #903
Conversation
minesh-s-patel
commented
Jan 22, 2025
•
minesh-s-patel
commented
- Moved integration tests using J17
There was a problem hiding this comment.
This seems unnecessary?
| @@ -31,10 +31,10 @@ Workflow { | |||
| } | |||
| runtimeTest = { | |||
There was a problem hiding this comment.
I think this should actually refer to the test utility project. It's where Xtext will generate it's test utilities.
There was a problem hiding this comment.
When the MWE2 runtimeTest points to rosetta-testing
The issue is that it generates 2 things
- A Unit test (in
rosetta-testing/src/test) - which is a Hello World test intended to be overriden. - A type called RosettaInjectorProvider.java which (in
rosetta-testing/src/main) which we need in the testing utils
When I just moved the all the tests to integration testing - it started to generate point 1 which caused a unit test failure.
When I move the MWE2 runtimeTest to point to rosetta-integration-tests, then we are generating point 2 int he wrong place.
I made a change to just disable the runtime test automation. The automation is meant to be a starting point and does not really (I think) provide much value any more.
The other option is that we move the MWE2 runtimeTest back to rosetta-testing, and check in the generated xtend test and live with 1 test being in rosetta-testing. I prefer the first option. @SimonCockx - take a look at the PR now and tell me what you think.
