Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Move superchainProxy admin from opcm upgrade() to constructor() #13989

Merged
merged 6 commits into from
Jan 27, 2025

Conversation

maurelian
Copy link
Contributor

@maurelian maurelian commented Jan 26, 2025

Moves the superchainProxyAdmin from the upgrade() function to the constructor to ensure it's immutable and consistently available.

Copy link
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@maurelian maurelian marked this pull request as ready for review January 26, 2025 16:18
@maurelian maurelian requested a review from a team as a code owner January 26, 2025 16:18
@maurelian maurelian requested review from mds1 and removed request for a team January 26, 2025 16:18
Copy link

codecov bot commented Jan 26, 2025

Codecov Report

Attention: Patch coverage is 36.36364% with 7 lines in your changes missing coverage. Please review.

Project coverage is 46.58%. Comparing base (521b027) to head (6e92c58).

Files with missing lines Patch % Lines
...es/contracts-bedrock/src/L1/OPContractsManager.sol 22.22% 7 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           opcm/mt-cannon   #13989      +/-   ##
==================================================
+ Coverage           45.37%   46.58%   +1.21%     
==================================================
  Files                 916      973      +57     
  Lines               76804    81477    +4673     
  Branches              758      759       +1     
==================================================
+ Hits                34847    37954    +3107     
- Misses              39175    40574    +1399     
- Partials             2782     2949     +167     
Flag Coverage Δ
cannon-go-tests-32 61.99% <ø> (?)
cannon-go-tests-64 56.62% <ø> (?)
contracts-bedrock-tests 90.06% <30.00%> (-0.36%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
op-deployer/pkg/deployer/opcm/implementations.go 0.00% <ø> (ø)
...-deployer/pkg/deployer/pipeline/implementations.go 86.76% <100.00%> (+0.19%) ⬆️
...racts-bedrock/src/L1/OPContractsManagerInterop.sol 100.00% <100.00%> (+28.57%) ⬆️
...es/contracts-bedrock/src/L1/OPContractsManager.sol 70.71% <22.22%> (+0.07%) ⬆️

... and 74 files with indirect coverage changes

@maurelian maurelian force-pushed the opcm/no-sc-arg branch 2 times, most recently from 35ce75c to 49f8eba Compare January 26, 2025 16:32
@maurelian maurelian requested a review from a team as a code owner January 27, 2025 15:01
@maurelian maurelian requested review from sigma and removed request for a team January 27, 2025 15:01
@maurelian maurelian requested a review from a team as a code owner January 27, 2025 15:19
@maurelian maurelian requested review from axelKingsley and removed request for a team January 27, 2025 15:19
@maurelian maurelian merged commit 3a6a5be into opcm/mt-cannon Jan 27, 2025
42 of 44 checks passed
@maurelian maurelian deleted the opcm/no-sc-arg branch January 27, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants