-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Move superchainProxy admin from opcm upgrade() to constructor() #13989
Conversation
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## opcm/mt-cannon #13989 +/- ##
==================================================
+ Coverage 45.37% 46.58% +1.21%
==================================================
Files 916 973 +57
Lines 76804 81477 +4673
Branches 758 759 +1
==================================================
+ Hits 34847 37954 +3107
- Misses 39175 40574 +1399
- Partials 2782 2949 +167
Flags with carried forward coverage won't be shown. Click here to find out more.
|
35ce75c
to
49f8eba
Compare
49f8eba
to
30860f3
Compare
536db56
to
585b34a
Compare
585b34a
to
536db56
Compare
Moves the superchainProxyAdmin from the upgrade() function to the constructor to ensure it's immutable and consistently available.