Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OPCM upgrade: Add MTCannon to OPCM #13979

Merged
merged 23 commits into from
Jan 27, 2025
Merged

OPCM upgrade: Add MTCannon to OPCM #13979

merged 23 commits into from
Jan 27, 2025

Conversation

maurelian
Copy link
Contributor

@maurelian maurelian commented Jan 25, 2025 •
edited
Loading

  • Renames mipsImpl to mips64Impl in the Implementations struct
  • Adds a new prestateHash input value for each new game.

@maurelian maurelian mentioned this pull request Jan 25, 2025
Merged
@maurelian Graphite App
Copy link
Contributor Author

maurelian commented Jan 25, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Base automatically changed from opcm-up/superchain-singletons to develop January 25, 2025 17:32
@codecov Codecov
Copy link

codecov bot commented Jan 25, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 10.71429% with 25 lines in your changes missing coverage. Please review.

Project coverage is 81.53%. Comparing base (4720bc7) to head (3a6a5be).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
...es/contracts-bedrock/src/L1/OPContractsManager.sol 7.40% 25 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##           develop   #13979       +/-   ##
============================================
+ Coverage    46.59%   81.53%   +34.94%     
============================================
  Files          973      111      -862     
  Lines        81468     5054    -76414     
  Branches       757      759        +2     
============================================
- Hits         37961     4121    -33840     
+ Misses       40590      870    -39720     
+ Partials      2917       63     -2854
Flag Coverage Δ
cannon-go-tests-32 ?
cannon-go-tests-64 ?
contracts-bedrock-tests 87.73% <10.71%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...racts-bedrock/src/L1/OPContractsManagerInterop.sol 100.00% <100.00%> (+28.57%) ⬆️
...es/contracts-bedrock/src/L1/OPContractsManager.sol 70.71% <7.40%> (-1.16%) ⬇️

... and 866 files with indirect coverage changes

@maurelian maurelian changed the base branch from develop to graphite-base/13979 January 25, 2025 21:53
@maurelian maurelian force-pushed the graphite-base/13979 branch from 4720bc7 to 2caadac Compare January 25, 2025 21:53
@maurelian maurelian changed the base branch from graphite-base/13979 to develop January 25, 2025 21:53
@maurelian maurelian changed the base branch from develop to graphite-base/13979 January 25, 2025 21:54
@maurelian maurelian force-pushed the graphite-base/13979 branch from 4720bc7 to 2caadac Compare January 25, 2025 21:54
@maurelian maurelian changed the base branch from graphite-base/13979 to opcm/dedupe-ext-calls January 25, 2025 21:54
@maurelian maurelian mentioned this pull request Jan 25, 2025
Draft
@maurelian maurelian changed the base branch from opcm/dedupe-ext-calls to graphite-base/13979 January 25, 2025 22:05
@maurelian maurelian force-pushed the graphite-base/13979 branch from 2caadac to 4720bc7 Compare January 25, 2025 22:05
@maurelian maurelian changed the base branch from graphite-base/13979 to develop January 25, 2025 22:05
@maurelian maurelian marked this pull request as ready for review January 25, 2025 22:08
@maurelian maurelian requested a review from a team as a code owner January 25, 2025 22:08
@maurelian maurelian requested a review from Inphi January 25, 2025 22:08
@maurelian maurelian mentioned this pull request Jan 26, 2025
Merged
Inphi
Inphi approved these changes Jan 26, 2025
View reviewed changes
Copy link
Contributor

@Inphi Inphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We could simplify permissioned and permissionless prestates if it makes sense to do within OPCM.

packages/contracts-bedrock/interfaces/L1/IOPContractsManager.sol Outdated Show resolved Hide resolved
@maurelian maurelian mentioned this pull request Jan 27, 2025
Open
@maurelian maurelian added this pull request to the merge queue Jan 27, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 27, 2025
@maurelian maurelian requested a review from a team as a code owner January 27, 2025 16:03
@maurelian maurelian requested a review from protolambda January 27, 2025 16:03
@maurelian maurelian added this pull request to the merge queue Jan 27, 2025
Merged via the queue into develop with commit 51b2632 Jan 27, 2025
43 of 44 checks passed
@maurelian maurelian deleted the opcm/mt-cannon branch January 27, 2025 16:50
samlaf pushed a commit to Layr-Labs/optimism that referenced this pull request Jan 27, 2025
@maurelian @mds1 @samlaf
OPCM upgrade: Add MTCannon to OPCM (ethereum-optimism#13979)
4445c2e 
* mtcannon upgrade notes

* mtcannon upgrade strawman impl

* rename mips to mips64

* feat: rename _currentGame to _disputeGame

* feat: Move has input into the OpChain struct, and take one per game

* bump semvers

* feat: rename OpChains to OpChainConfigs and mips to mips64

* feat: Add PrestateNotSet error and tests

* test fixes

* fix snapshots and interfaces

* fix empty prestate tests

* semver

* update arg name to _opChainConfig

* Deploy Mips64 in test

* Address feedback in OPCM.t.sol

* refactor: only take one absolute prestate per chain

* feat: Move superchainProxy admin from opcm upgrade() to constructor()

* Make use of named variable in deploy.s.sol

* feat: Add state var checks to ChainAssertsion.checkOPCM

* wip: adding SuperchainProxyAdmin to op-deployer

* fix: Correct check of scc and pv impls in chainAssertions.opcm

* lint and fix unused import

---------

Co-authored-by: Matt Solomon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mds1 mds1 mds1 left review comments

@Inphi Inphi Inphi approved these changes

@protolambda protolambda Awaiting requested review from protolambda protolambda is a code owner automatically assigned from ethereum-optimism/go-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maurelian @Inphi @mds1