Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Robustness: Improve the documentation #19123

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Robustness: Improve the documentation #19123

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions tests/robustness/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,13 +86,13 @@ Etcd provides strict serializability for KV operations and eventual consistency

## Running locally

1. Build etcd with failpoints
1. Build etcd with failpoints. Please make sure that you are at the root directory of the repository before performing below steps.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is only one makefile in the project localted in the root directory, and all commands should be run from root.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. I guess then this PR is not required

```bash
make gofail-enable
make -f tests/robustness/makefile.mk gofail-enable
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-f is not needed

make build
make gofail-disable
make -f tests/robustness/makefile.mk gofail-disable
```
2. Run the tests
2. Run the tests from the root directory of the repository only.

```bash
make test-robustness
Expand Down