Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Robustness: Improve the documentation #19123

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Robustness: Improve the documentation #19123

wants to merge 1 commit into from

Conversation

amentee
Copy link

@amentee amentee commented Jan 3, 2025

Included the correct path of the makefile to build the failpoints targets

Signed-off-by: Sachin Kumar [email protected]

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: amentee
Once this PR has been reviewed and has the lgtm label, please assign serathius for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link

Hi @amentee. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Robustness: Improve the documentation
81ccac2 
Included the path of the makefile to build the failpoints

Signed-off-by: Kumar, Sachin <[email protected]>
@amentee amentee force-pushed the feature/robustness_documentation branch from 631a716 to 81ccac2 Compare January 3, 2025 15:24
serathius
serathius reviewed Jan 3, 2025
View reviewed changes
tests/robustness/README.md
```bash
make gofail-enable
make -f tests/robustness/makefile.mk gofail-enable
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-f is not needed

serathius
serathius reviewed Jan 3, 2025
View reviewed changes
tests/robustness/README.md
@@ -86,13 +86,13 @@ Etcd provides strict serializability for KV operations and eventual consistency

## Running locally

1. Build etcd with failpoints
1. Build etcd with failpoints. Please make sure that you are at the root directory of the repository before performing below steps.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is only one makefile in the project localted in the root directory, and all commands should be run from root.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. I guess then this PR is not required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serathius serathius serathius left review comments

Assignees
No one assigned
Labels
area/robustness-testing area/testing needs-ok-to-test size/XS
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amentee @k8s-ci-robot @serathius