Openmp merge #237
Open
Openmp merge #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--HG-- branch : week-of-code
--HG-- branch : week-of-code
--HG-- branch : week-of-code
- SubgridSizeAutoAdjust to TRUE (up to 30% increases in speed reported). - Optimized CommunicationTransferParticles ON. Was bracketed by the OPTIMIZED_CTP define before. --HG-- branch : week-of-code
Placing the HD cooling curve fit ceiling lower at T ~ 1e5K to avoid overflows (inf) in the tables at T > 1e6K. --HG-- branch : week-of-code
--HG-- branch : week-of-code
changed to the default behavior. --HG-- branch : week-of-code
--HG-- branch : week-of-code
--HG-- branch : week-of-code
--HG-- branch : week-of-code
FLOAT. Maybe this was causing some "misplaced" photons when ray merging is used? --HG-- branch : week-of-code
tree built for ray merging. Not working. --HG-- branch : week-of-code
tree built for ray merging. Not working. --HG-- branch : week-of-code
--HG-- branch : litemp
--HG-- branch : litemp
corruption. No idea why this happens, but it fixed the problem in the open-mp branch. --HG-- branch : litemp
conservative or positive reconstruction yet. --HG-- branch : litemp
--HG-- branch : litemp
--HG-- branch : litemp
Needed to change ijk (MAX_ANY_SINGLE_DIRECTION) to the maximum dimension in the grid. For some reason, it was causing memory corruption issues in the rate solver. --HG-- branch : litemp
--HG-- branch : litemp
--HG-- branch : litemp
…ores. --HG-- branch : litemp
--HG-- branch : litemp
Fortran didn't like multiple threads writing to the same file, e.g. write(4,*). Ifdef'ed them out if OpenMP is on. --HG-- branch : litemp
--HG-- branch : litemp
--HG-- branch : litemp
instead of MPI processes. Removed some minor memory leaks. --HG-- branch : litemp
--HG-- branch : litemp
--HG-- branch : week-of-code
--HG-- branch : litemp
--HG-- branch : litemp
First application will be for ray tracing. --HG-- branch : litemp
timers to multiple values. The Ray_Segment field is still being corrupted in parallel jobs, which is introduced in the earlier changeset to avoid interpolation of this field. --HG-- branch : litemp
regions with child grids, i.e. rays are only traced on the finest level. --HG-- branch : litemp
--HG-- branch : litemp
MoveToGrid was computed incorrectly. --HG-- branch : litemp
pragma since it was causing crashes. --HG-- branch : litemp
--HG-- branch : cjmp
--HG-- branch : cjmp
--HG-- branch : cjmp
--HG-- branch : cjmp
--HG-- branch : cjmp
…ionInitialize.C --HG-- branch : cjmp
--HG-- branch : cjmp
|
@cjllorente827 could you please (1) update the text of the PR to explain what you're doing with it, and (2) fix the code so it passes the tests? Thank you! Edit: looking at the error messages it seems that you have a compilation problem. It should be easy to fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: Pull request
about: Create a pull request to help us improve
title: ''
labels: ''
assignees: ''
Thank you so much for your PR! To help us review, fill out the form to the best of your ability. Please make use of the development guide at https://enzo.readthedocs.io/en/latest/developer_guide/ModificationIntro.html#how-to-develop-enzo
Pull request summary
Provide a general summary of your changes in the title above, for example "Fixes crash in FluxCorrection between AMR levels". Please avoid non-descriptive titles such as "Addresses issue #42."
If you are able to do so, please do not create the PR out of main, but out of a separate branch.
Describe your pull request
Please provide at least 1-2 sentences describing the pull request in detail. Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here. Github will autolink if prefixed with a hash, e.g. #42.
If your PR depends on another PR, please link to the PR here github autolinking syntax.
[ ] This is a major change or addition. Will require two reviewers.
PR Checklist
Note that some of these check boxes may not apply to all pull requests.
Thank you!
We understand that PRs can sometimes be overwhelming, especially as the
reviews start coming in. Please let us know if the reviews are unclear or the
recommended next step seems overly demanding, or if you would like help in
addressing a reviewer's comments. Lastly, please ping us if you've been waiting
too long to hear back on your PR.