build: setups for container images #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Takeshi Yoneda <[email protected]>
mathetake
requested review from
aabchoo,
missBerg and
wengyao04
as code owners
mathetake
commented
Dec 3, 2024
| @@ -0,0 +1,63 @@ | |||
| name: Docker Builds Template | |||
There was a problem hiding this comment.
note: make this as a template since it will be used "release" workflow in the future
Signed-off-by: Takeshi Yoneda <[email protected]>
wengyao04
approved these changes
Dec 5, 2024
wengyao04
pushed a commit
that referenced
this pull request
Dec 5, 2024
This is a follow up on #18 - verified it's working: * https://github.com/envoyproxy/ai-gateway/pkgs/container/ai-gateway%2Fcontroller * https://github.com/envoyproxy/ai-gateway/pkgs/container/ai-gateway%2Fextproc --------- Signed-off-by: Takeshi Yoneda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit set ups the container images build in Makefile
as well as in the CI. A new GHA job template is added also,
which will be used in the release workflow in the future.
All makefile recipes come with the detail comments in order to
make it easier.