ci: fixes docker push command (#24)

This is a follow up on #18 - verified it's working: * https://github.com/envoyproxy/ai-gateway/pkgs/container/ai-gateway%2Fcontroller * https://github.com/envoyproxy/ai-gateway/pkgs/container/ai-gateway%2Fextproc --------- Signed-off-by: Takeshi Yoneda <[email protected]>
envoyproxy · Dec 5, 2024 · 8719beb · 8719beb
1 parent ea81a08
commit 8719beb
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/.github/workflows/commit.yaml b/.github/workflows/commit.yaml
@@ -54,4 +54,5 @@ jobs:
         run: make test
 
   docker_builds:
+    name: Docker Build and/or Push
     uses: ./.github/workflows/docker_builds_template.yaml
diff --git a/.github/workflows/docker_builds_template.yaml b/.github/workflows/docker_builds_template.yaml
@@ -5,7 +5,7 @@ on:
 
 jobs:
   docker_builds:
-    name: Build and/or Push Docker Images
+    name: ${{ matrix.target.command_name }}
     runs-on: ubuntu-latest
     strategy:
       matrix:
@@ -53,11 +53,10 @@ jobs:
       # * Only use the tag if the event is a tag event, otherwise use "latest".
       # * Build for both amd64 and arm64 platforms.
       - name: Build and Push Image
-        if: github.event_name == 'push'
         run: |
           if [[ "$GITHUB_REF" == refs/tags/* ]]; then
             TAG="${GITHUB_REF#refs/tags/}"
           else
             TAG="latest"
           fi
-          make docker-build.${{ matrix.target.command_name }} ENABLE_MULTI_PLATFORMS=true TAG=$TAG BUILDX_ARGS="--push"
+          make docker-build.${{ matrix.target.command_name }} ENABLE_MULTI_PLATFORMS=true TAG=$TAG DOCKER_BUILD_ARGS="--push"