[Inference API] Remove rate limiting feature flag check in BaseTransportInferenceAction and rely on noop implementation #121270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Noop implementation
timgrein
added
>non-issue
:ml
|
Pinging @elastic/ml-core (Team:ML) |
…lag-check-in-transport
timgrein
requested review from
vidok,
maxjakob,
demjened,
jaybcee and
brendan-jugan-elastic
maxjakob
reviewed
Jan 30, 2025
...nce/src/main/java/org/elasticsearch/xpack/inference/action/BaseTransportInferenceAction.java
Show resolved
Hide resolved
maxjakob
approved these changes
Jan 30, 2025
jonathan-buttner
approved these changes
Jan 30, 2025
timgrein
added a commit
to timgrein/elasticsearch
that referenced
this pull request
Feb 4, 2025
… Noop implementation (elastic#121270) (cherry picked from commit 0a8605e)
timgrein
added a commit
to timgrein/elasticsearch
that referenced
this pull request
Feb 4, 2025
… Noop implementation (elastic#121270) (cherry picked from commit 0a8605e)
timgrein
added a commit
to timgrein/elasticsearch
that referenced
this pull request
Feb 4, 2025
… Noop implementation (elastic#121270) (cherry picked from commit 0a8605e)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up for #120400. We now provide a noop rate limiting implementation inside the InferencePlugin, if the feature flag is disabled. The noop implementation will always return false for
isTaskTypeReroutingSupportedregardless of the service/task-type pair.