[Inference API] Fix tests in TransportInferenceActionTests #121302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Exception_FromOtherNode failing
timgrein
added
>test
|
Pinging @elastic/ml-core (Team:ML) |
timgrein
changed the title
jonathan-buttner
approved these changes
Jan 30, 2025
| issue: https://github.com/elastic/elasticsearch/issues/121292 | ||
| - class: org.elasticsearch.xpack.inference.action.TransportInferenceActionTests | ||
| method: testRerouting_ToOtherNode | ||
| issue: https://github.com/elastic/elasticsearch/issues/121293 | ||
| - class: org.elasticsearch.xpack.inference.common.InferenceServiceNodeLocalRateLimitCalculatorTests | ||
| issue: https://github.com/elastic/elasticsearch/issues/121294 |
There was a problem hiding this comment.
Should we unmute this one too? Or is that a separate issue?
There was a problem hiding this comment.
This is a separate issue. I've ran the test with my changes and the reproduction command and it still failed.
There was a problem hiding this comment.
PR for the other CI issue: #121379
💔 Backport failed
You can use sqren/backport to manually backport by running |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 31, 2025
timgrein
added a commit
that referenced
this pull request
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #121292
Fixes #121293
Similar to #121270 + adjusted the tests to make some more verifications. The feature flag kicked in and returned from the
determineRoutingmethod before the mocks were called.