Refactor semantic text field to align with text field behaviour #119183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the original field
|
Documentation preview: |
|
Pinging @elastic/search-eng (Team:SearchOrg) |
|
Pinging @elastic/search-relevance (Team:Search - Relevance) |
|
Hi @jimczi, I've created a changelog YAML for you. |
Mikep86
reviewed
Dec 23, 2024
docs/reference/search/search-your-data/semantic-search-semantic-text.asciidoc
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/index/engine/TranslogDirectoryReader.java
Outdated
Show resolved
Hide resolved
Mikep86
approved these changes
Dec 23, 2024
...ain/java/org/elasticsearch/xpack/inference/mapper/SemanticInferenceMetadataFieldsMapper.java
Outdated
Show resolved
Hide resolved
...nce/src/test/java/org/elasticsearch/xpack/inference/mapper/SemanticTextFieldMapperTests.java
Outdated
Show resolved
Hide resolved
...nce/src/test/java/org/elasticsearch/xpack/inference/mapper/SemanticTextFieldMapperTests.java
Outdated
Show resolved
Hide resolved
...nce/src/test/java/org/elasticsearch/xpack/inference/mapper/SemanticTextFieldMapperTests.java
Outdated
Show resolved
Hide resolved
jimczi
added a commit
to jimczi/elasticsearch
that referenced
this pull request
Dec 30, 2024
…tic#119183) Co-authored-by: Mike Pellegrini <[email protected]>
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 30, 2024
#119339) * Refactor semantic text field to align with text field behaviour (#119183) Co-authored-by: Mike Pellegrini <[email protected]> * fix compil after backport * fix compil after backport (bis) --------- Co-authored-by: Mike Pellegrini <[email protected]>
jimczi
added a commit
to jimczi/elasticsearch
that referenced
this pull request
Jan 6, 2025
This change adapts the semantic highlighter to work with the new format introduced in elastic#119183.
jimczi
added a commit
to jimczi/elasticsearch
that referenced
this pull request
Jan 6, 2025
This change adapts the semantic highlighter to work with the new format introduced in elastic#119183.
jimczi
added a commit
that referenced
this pull request
Jan 7, 2025
#119604) This change adapts the semantic highlighter to work with the new format introduced in #119183. Co-authored-by: Kathleen DeRusso <[email protected]>
jimczi
added a commit
to jimczi/elasticsearch
that referenced
this pull request
Jan 7, 2025
elastic#119604) This change adapts the semantic highlighter to work with the new format introduced in elastic#119183. Co-authored-by: Kathleen DeRusso <[email protected]>
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 7, 2025
#119604) (#119657) This change adapts the semantic highlighter to work with the new format introduced in #119183. Co-authored-by: Kathleen DeRusso <[email protected]>
jimczi
added a commit
to jimczi/elasticsearch
that referenced
this pull request
Jan 30, 2025
The semantic text format was updated in elastic#119183. This commit removes the last remaining reference to the old format from the documentation to ensure consistency.
leemthompo
pushed a commit
that referenced
this pull request
Jan 30, 2025
The semantic text format was updated in #119183. This commit removes the last remaining reference to the old format from the documentation to ensure consistency.
jimczi
added a commit
to jimczi/elasticsearch
that referenced
this pull request
Jan 30, 2025
…21276) The semantic text format was updated in elastic#119183. This commit removes the last remaining reference to the old format from the documentation to ensure consistency.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the semantic text field to function similarly to a standard text field. The original source content is preserved, while embedding chunks are retrieved from:
The new format is not enabled by default. An internal index setting is used to enable the new format, allowing for a controlled transition. The switch to the new format will be implemented in a subsequent PR.
Highlighting support is also missing (for the new format) and will be added in a follow up.
Note: Individual commits were reviewed in the original branch for clarity.
This PR is intended for merging rather than detailed review.