Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated reference to internal semantic text format #121276

Merged
merged 2 commits into from
Jan 30, 2025

Conversation

jimczi
Copy link
Contributor

@jimczi jimczi commented Jan 30, 2025

The semantic text format was updated in #119183. This commit removes the last remaining reference to the old format from the documentation to ensure consistency.

The semantic text format was updated in elastic#119183. This commit removes the last remaining reference to the old format from the documentation to ensure consistency.
@jimczi jimczi added >docs General docs changes :SearchOrg/Relevance Label for the Search (solution/org) Relevance team v9.0.0 v8.18.0 labels Jan 30, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/search-eng (Team:SearchOrg)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/search-relevance (Team:Search - Relevance)

@leemthompo leemthompo added the auto-backport Automatically create backport pull requests when merged label Jan 30, 2025
Copy link
Member

@kderusso kderusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, but we may not be able to commit docs changes to 9.0 anymore - please ref @leemthompo 's communications about this.

@leemthompo
Copy link
Contributor

leemthompo commented Jan 30, 2025

This might just sneak through, but CI seems especially long on this one 😄

The two most important ones for docs changes have passed so I think it's safe:

buildkite/docs-build-pr
elasticsearch-ci/docs-check

Feels like elasticsearch-ci is stuck

@leemthompo leemthompo merged commit fb3c666 into elastic:main Jan 30, 2025
6 checks passed
@leemthompo
Copy link
Contributor

Merging to make sure the 8.x backport gets in, we'll need to verify that the changes were picked up in the new 9.0 docs ✏️ 🗒️

jimczi added a commit to jimczi/elasticsearch that referenced this pull request Jan 30, 2025
…21276)

The semantic text format was updated in elastic#119183. This commit removes the last remaining reference to the old format from the documentation to ensure consistency.
@jimczi
Copy link
Contributor Author

jimczi commented Jan 30, 2025

Thanks @leemthompo!

elasticsearchmachine pushed a commit that referenced this pull request Jan 30, 2025
…121289)

The semantic text format was updated in #119183. This commit removes the last remaining reference to the old format from the documentation to ensure consistency.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged >docs General docs changes :SearchOrg/Relevance Label for the Search (solution/org) Relevance team v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants