Fix and issue with Request Logging and Improve the log detail #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am using this code and it is working correctly |
…ou only see the text nodes
… issues with deletion of request id
…nce, and so calling empty(xmldb:remove(...)) makes no sense as the result is always fn:true()
… issues with deletion of request id
adamretter
force-pushed
the
feature/improve-req-logging
branch
from
ef61936 to
1e2ce86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where the request was not serialized before it was logged which meant you could only see its text nodes in the log and not the XML elements. It also makes a small improvement by logging some additional detail around whether request ids exist or not.