Fix an issue with request id deletion happening too early #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Without this fix, authentication process fails systematically. |
…ou only see the text nodes
… issues with deletion of request id
…nce, and so calling empty(xmldb:remove(...)) makes no sense as the result is always fn:true()
… issues with deletion of request id
…rocess. Previously, as the exsaml:check-authnreqid function is called twice, it was unfortunately deleting the SAML request id during the first call, and so the second call always returns an error which interrupts the authentication process. This commit fixes the issue by ensuring the request id is only deleted when it is finished with.
adamretter
force-pushed
the
hotfix/request-id-deletion
branch
from
b0eff7a to
a71b384
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The request id was being deleted at the wrong stage in the process. Previously, as the exsaml:check-authnreqid function is called twice, it was unfortunately deleting the SAML request id during the first call, and so the second call always returns an error which interrupts the authentication process. This commit (b0eff7a) fixes the issue by ensuring the request id is only deleted when it is finished with.
NOTE this PR is stacked atop PR #34 (which was used to diagnose the issue), and so please merge PR #34 BEFORE merging this PR.