Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle also main as DUCKDB_GIT_VERSION for C-API extensions #126

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

carlopi
Copy link
Collaborator

@carlopi carlopi commented Jan 6, 2025

Currently using DUCKDB_GIT_VERSION=main fails for C-API extensions since main is not a valid version.

Default to latest then when installing the Pyhton-based package.

Tests of this working are at https://github.com/carlopi/extension-ci-tools/actions/runs/12633104809/job/35198062606, where a second problem is shown connected to hardcoding MINIMUM_DUCDKB_VERSION, to be solved independently.

@carlopi carlopi requested a review from samansmink January 6, 2025 13:28
Copy link
Collaborator

@samansmink samansmink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how useful this is by itself due to the fact that you will manually need to figure out which duckdb version is latest unstable on PyPI. Does not hurt either I guess

@carlopi
Copy link
Collaborator Author

carlopi commented Jan 6, 2025

Not sure how useful this is by itself due to the fact that you will manually need to figure out which duckdb version is latest unstable on PyPI. Does not hurt either I guess

I think as long as latest duckdb is "about v1.2.0 or above", it should be fine to use main to test this right?
I bumped against this while running CI using main, works already when building also duckdb, with this in works also for C-API extensions (they will get a recent duckdb build).

We might consider fixing it to use latest stable, but currently given v1.2.0-compatible CAPI are not released yet, only recent nightly can be used.

@carlopi carlopi merged commit 0cd9d80 into duckdb:main Jan 6, 2025
41 checks passed
@carlopi carlopi deleted the handle_main_capi_tests branch January 6, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants