Skip to content

Commit

Permalink
Handle also main as DUCKDB_GIT_VERSION for C-API extensions, defaul…
Browse files Browse the repository at this point in the history
…t to latest available Python package
  • Loading branch information
carlopi committed Jan 6, 2025
1 parent 95cbb76 commit 0cd9d80
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions makefiles/c_api_extensions/base.Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -101,11 +101,12 @@ TEST_RUNNER_RELEASE=$(TEST_RUNNER_BASE) --external-extension build/release/$(EXT

# By default latest duckdb is installed, set DUCKDB_TEST_VERSION to switch to a different version
DUCKDB_INSTALL_VERSION?=
DUCKDB_INSTALL_OPTIONS?=
ifneq ($(DUCKDB_TEST_VERSION),)
DUCKDB_INSTALL_VERSION===$(DUCKDB_TEST_VERSION)
endif

ifneq ($(DUCKDB_GIT_VERSION),)
else ifeq ($(DUCKDB_GIT_VERSION),main)
DUCKDB_INSTALL_OPTIONS= --pre
else ifneq ($(DUCKDB_GIT_VERSION),)
DUCKDB_INSTALL_VERSION===$(DUCKDB_GIT_VERSION)
endif

Expand Down Expand Up @@ -223,7 +224,7 @@ venv: configure/venv

configure/venv:
$(PYTHON_BIN) -m venv configure/venv
$(PYTHON_VENV_BIN) -m pip install 'duckdb$(DUCKDB_INSTALL_VERSION)'
$(PYTHON_VENV_BIN) -m pip install 'duckdb$(DUCKDB_INSTALL_VERSION)' $(DUCKDB_INSTALL_OPTIONS)
$(PYTHON_VENV_BIN) -m pip install git+https://github.com/duckdb/duckdb-sqllogictest-python

#############################################
Expand Down

0 comments on commit 0cd9d80

Please sign in to comment.