Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to extra manual steps to fix the looping security popup #21743

Merged
merged 6 commits into from
Jan 9, 2025
+25 −6
Merged

Add link to extra manual steps to fix the looping security popup #21743

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b997350
Add link to extra manual steps to fix the looping security popup
mat007 Jan 9, 2025
fff4ce2
Update content/manuals/desktop/release-notes.md
aevesdocker Jan 9, 2025
c455052
Add 'For Mac' header
aevesdocker Jan 9, 2025
e0ab100
More mentions of the malware security popup
mat007 Jan 9, 2025
386c8ab
Mention of the malware security popup in download and troubleshoot
mat007 Jan 9, 2025
e57ea7a
Apply suggestions from code review
aevesdocker Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions content/manuals/desktop/release-notes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,12 @@

- Prevents a bug that caused Docker Desktop to not update `com.docker.vmnetd` or `com.docker.socket` to newer versions.

### Known issues
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just spotted, this needs to be moved under 4.37.1

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And 4.37.0 as well. But we need to keep something for 4.37.2 here too as some people may already have the security popup, and just installing 4.37.2 isn’t going to be enough for them.
Maybe a note/banner a bit above for 4.37.2 and move the know issue to the rest of the 4.37.x releases?

Copy link
Contributor

@aevesdocker aevesdocker Jan 9, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that sounds good. On second thoughts, I'd actually have the banner temporarily above the 4.37.2 header - will make it more prominent.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps the 'warning' callout with "If you're experiencing issues on Mac, either download version 4.32.2 below, or follow the workaround detailed in docker/for-mac#7527"

Copy link
Contributor

@aevesdocker aevesdocker Jan 9, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the note also be temporarily added to the install or troubleshooting pages?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah there was already a similar known issue for 4.37.1, we should replace it with this one, linking to the GitHub issue, instead of the instructions directly.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the note also be temporarily added to the install or troubleshooting pages?

Yes, good call!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aevesdocker are looking into doing all these changes, or do you want me to look at it?

Copy link
Contributor

@aevesdocker aevesdocker Jan 9, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'll be quicker if you do it as I can then just merge it, rather than me waiting for someone in the docs team to approve

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the release notes, and will look at install and troubleshooting.


aevesdocker marked this conversation as resolved.
Show resolved Hide resolved
#### For Mac

- If you’re seeing a security popup about malware on `com.docker.vmnetd` or `com.docker.socket`, follow the steps documented in [docker/for-mac#7527](https://github.com/docker/for-mac/issues/7527).

Check failure on line 42 in content/manuals/desktop/release-notes.md

View workflow job for this annotation

GitHub Actions / vale 

[vale] reported by reviewdog 🐶
[Vale.Terms] Use 'Mac' instead of 'mac'.

Raw Output:
{"message": "[Vale.Terms] Use 'Mac' instead of 'mac'.", "location": {"path": "content/manuals/desktop/release-notes.md", "range": {"start": {"line": 42, "column": 141}}}, "severity": "ERROR"}

## 4.37.1

{{< release-date date="2024-12-17" >}}
Expand Down