-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add link to extra manual steps to fix the looping security popup #21743
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @mat007
@@ -35,6 +35,12 @@ Take a look at the [Docker Public Roadmap](https://github.com/orgs/docker/projec | |||
|
|||
- Prevents a bug that caused Docker Desktop to not update `com.docker.vmnetd` or `com.docker.socket` to newer versions. | |||
|
|||
### Known issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just spotted, this needs to be moved under 4.37.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And 4.37.0 as well. But we need to keep something for 4.37.2 here too as some people may already have the security popup, and just installing 4.37.2 isn’t going to be enough for them.
Maybe a note/banner a bit above for 4.37.2 and move the know issue to the rest of the 4.37.x releases?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes that sounds good. On second thoughts, I'd actually have the banner temporarily above the 4.37.2 header - will make it more prominent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps the 'warning' callout with "If you're experiencing issues on Mac, either download version 4.32.2 below, or follow the workaround detailed in docker/for-mac#7527"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the note also be temporarily added to the install or troubleshooting pages?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah there was already a similar known issue for 4.37.1, we should replace it with this one, linking to the GitHub issue, instead of the instructions directly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the note also be temporarily added to the install or troubleshooting pages?
Yes, good call!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aevesdocker are looking into doing all these changes, or do you want me to look at it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'll be quicker if you do it as I can then just merge it, rather than me waiting for someone in the docs team to approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the release notes, and will look at install and troubleshooting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Description
Related issues or tickets
Reviews