Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to extra manual steps to fix the looping security popup #21743

Merged
merged 6 commits into from
Jan 9, 2025

Conversation

mat007
Copy link
Member

@mat007 mat007 commented Jan 9, 2025

Description

Related issues or tickets

Reviews

  • Technical review
  • Editorial review
  • Product review

@github-actions github-actions bot added the area/desktop Issue affects a desktop edition of Docker. E.g docker for mac label Jan 9, 2025
Copy link

netlify bot commented Jan 9, 2025

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit e57ea7a
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/677f9ff53a11b00008e1e545
😎 Deploy Preview https://deploy-preview-21743--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@gtardif gtardif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mat007 mat007 marked this pull request as ready for review January 9, 2025 09:00
@mat007 mat007 requested a review from aevesdocker as a code owner January 9, 2025 09:00
aevesdocker
aevesdocker previously approved these changes Jan 9, 2025
Copy link
Contributor

@aevesdocker aevesdocker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mat007

aevesdocker
aevesdocker previously approved these changes Jan 9, 2025
@@ -35,6 +35,12 @@ Take a look at the [Docker Public Roadmap](https://github.com/orgs/docker/projec

- Prevents a bug that caused Docker Desktop to not update `com.docker.vmnetd` or `com.docker.socket` to newer versions.

### Known issues
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just spotted, this needs to be moved under 4.37.1

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And 4.37.0 as well. But we need to keep something for 4.37.2 here too as some people may already have the security popup, and just installing 4.37.2 isn’t going to be enough for them.
Maybe a note/banner a bit above for 4.37.2 and move the know issue to the rest of the 4.37.x releases?

Copy link
Contributor

@aevesdocker aevesdocker Jan 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that sounds good. On second thoughts, I'd actually have the banner temporarily above the 4.37.2 header - will make it more prominent.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps the 'warning' callout with "If you're experiencing issues on Mac, either download version 4.32.2 below, or follow the workaround detailed in docker/for-mac#7527"

Copy link
Contributor

@aevesdocker aevesdocker Jan 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the note also be temporarily added to the install or troubleshooting pages?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah there was already a similar known issue for 4.37.1, we should replace it with this one, linking to the GitHub issue, instead of the instructions directly.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the note also be temporarily added to the install or troubleshooting pages?

Yes, good call!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aevesdocker are looking into doing all these changes, or do you want me to look at it?

Copy link
Contributor

@aevesdocker aevesdocker Jan 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'll be quicker if you do it as I can then just merge it, rather than me waiting for someone in the docs team to approve

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the release notes, and will look at install and troubleshooting.

@mat007 mat007 mentioned this pull request Jan 9, 2025
3 tasks
Copy link
Contributor

@aevesdocker aevesdocker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@aevesdocker aevesdocker merged commit 2d87e9b into docker:main Jan 9, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/desktop Issue affects a desktop edition of Docker. E.g docker for mac
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants