Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding delete collection #30

Merged
merged 8 commits into from
Sep 19, 2024
Merged

Conversation

JackLewis-digirati
Copy link
Collaborator

@JackLewis-digirati JackLewis-digirati commented Sep 17, 2024

Resolves #22

This PR adds the ability to delete a collection

The format for this request is DELETE {base URL}/{customer id}/collections/{collection id}

In order to perform a delete, the request must be authorized and have a X-IIIF-CS-Show-Extras header

@JackLewis-digirati JackLewis-digirati force-pushed the feature/deleteStorageCollection branch 2 times, most recently from 7b28fe5 to 733b424 Compare September 18, 2024 10:58
@JackLewis-digirati JackLewis-digirati changed the title Feature/delete storage collection Adding delete collection Sep 18, 2024
Copy link
Member

@donaldgray donaldgray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, couple of minor comments. Also, I'm not sure but should ETag be required for deletion?

@JackLewis-digirati JackLewis-digirati force-pushed the feature/deleteStorageCollection branch from 4269e8b to 87c86b4 Compare September 18, 2024 15:57
@JackLewis-digirati JackLewis-digirati merged commit 12f3c17 into main Sep 19, 2024
3 checks passed
@JackLewis-digirati JackLewis-digirati deleted the feature/deleteStorageCollection branch September 19, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete a Storage Collection
3 participants