Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Impl #201 - Create Space if manifest asset posted w/o space #229

Merged
merged 4 commits into from
Jan 17, 2025
Merged

Impl #201 - Create Space if manifest asset posted w/o space #229

merged 4 commits into from
Jan 17, 2025

Conversation

p-kaczynski
Copy link
Contributor

Implements #201

As per clarifications on slack, changed the BadRequest response into "create space and continue" that leads to 201 Created.

  • Change order of operations to reduce risk of creating unused DLCS space
  • Manifest-Asset-Post - Change test for prev behaviour into the updated one
  • If asset with no space posted, create space

@p-kaczynski
Change order of operations to reduce risk of creating unused DLCS space
877070d 
As per #201 comment.

Required some bonus test update to prevent different conditions triggering before the one under test being encountered
@p-kaczynski
Manifest-Asset-Post - Change test for prev behaviour into the updated…
60ecab0 
… one
@p-kaczynski
If asset with no space posted, create space
69768e6
donaldgray
donaldgray approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@donaldgray donaldgray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think the only thing is the error type returned if space generation fails

src/IIIFPresentation/API/Features/Manifest/ManifestService.cs Outdated Show resolved Hide resolved
@p-kaczynski p-kaczynski merged commit 6058b79 into main Jan 17, 2025
4 checks passed
@p-kaczynski p-kaczynski deleted the feature/201/handle_space_assets_posted branch January 17, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donaldgray donaldgray donaldgray approved these changes

@JackLewis-digirati JackLewis-digirati Awaiting requested review from JackLewis-digirati

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@p-kaczynski @donaldgray