Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing serialization error to provide a nicer error #218

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

JackLewis-digirati
Copy link
Collaborator

@JackLewis-digirati JackLewis-digirati commented Jan 13, 2025

Resolves #196

This PR updates PUT manifest to use the TryDeserialize method which improves handling of serialization errors so that a BadRequest is returned instead of an InternalServerError

@JackLewis-digirati JackLewis-digirati force-pushed the fix/niceSerializationError branch 2 times, most recently from 485c303 to 81b4634 Compare January 15, 2025 10:52
@JackLewis-digirati JackLewis-digirati marked this pull request as ready for review January 15, 2025 11:44
@JackLewis-digirati JackLewis-digirati force-pushed the fix/niceSerializationError branch from 7316c0e to b8b493c Compare January 16, 2025 14:14
@JackLewis-digirati JackLewis-digirati merged commit 751c160 into main Jan 16, 2025
4 checks passed
@JackLewis-digirati JackLewis-digirati deleted the fix/niceSerializationError branch January 16, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Supplying an invalid 'item' to a IIIF manifest results in 500
2 participants