-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding ability to update a manifest with details from the DLCS #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackLewis-digirati
force-pushed
the
feature/jobRunnerBatchCompletion
branch
from
January 9, 2025 16:49
ef617e4
to
c5ae07b
Compare
JackLewis-digirati
changed the title
initial commit adding ability to update the canvas_paintings table wi…
Adding ability to update ta manifest with details from the DLCS
Jan 9, 2025
JackLewis-digirati
changed the title
Adding ability to update ta manifest with details from the DLCS
Adding ability to update a manifest with details from the DLCS
Jan 9, 2025
JackLewis-digirati
requested review from
donaldgray,
tomcrane,
p-kaczynski and
griffri
January 13, 2025 15:55
donaldgray
reviewed
Jan 13, 2025
src/IIIFPresentation/BackgroundHandler/BatchCompletion/BatchCompletionMessageHandler.cs
Outdated
Show resolved
Hide resolved
src/IIIFPresentation/BackgroundHandler/BatchCompletion/BatchCompletionMessageHandler.cs
Outdated
Show resolved
Hide resolved
src/IIIFPresentation/BackgroundHandler/BatchCompletion/BatchCompletionMessageHandler.cs
Show resolved
Hide resolved
src/IIIFPresentation/BackgroundHandler/BatchCompletion/BatchCompletionMessageHandler.cs
Outdated
Show resolved
Hide resolved
src/IIIFPresentation/BackgroundHandler/BatchCompletion/BatchCompletionMessageHandler.cs
Outdated
Show resolved
Hide resolved
src/IIIFPresentation/BackgroundHandler/Helpers/ManifestMerger.cs
Outdated
Show resolved
Hide resolved
...IFPresentation/BackgroundHandler.Tests/BatchCompletion/BatchCompletionMessageHandlerTests.cs
Show resolved
Hide resolved
griffri
reviewed
Jan 14, 2025
JackLewis-digirati
force-pushed
the
feature/jobRunnerBatchCompletion
branch
from
January 14, 2025 17:03
8426672
to
09a4115
Compare
donaldgray
reviewed
Jan 14, 2025
src/IIIFPresentation/BackgroundHandler/Helpers/ManifestMerger.cs
Outdated
Show resolved
Hide resolved
src/IIIFPresentation/BackgroundHandler/BatchCompletion/BatchCompletionMessageHandler.cs
Outdated
Show resolved
Hide resolved
donaldgray
approved these changes
Jan 15, 2025
…th asset details from the DLCS
…nd tightening up how we get assets from the generated manifest body + general fixes
JackLewis-digirati
force-pushed
the
feature/jobRunnerBatchCompletion
branch
from
January 15, 2025 09:52
d1256c5
to
0d25f9a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves dlcs/protagonist#174
This PR makes it so that manifests are updated from the background handler after they've been completed in the DLCS.
There is 3 new DLCS settings, which are as follows:
OrchestratorUri
is the base address of the orchestrator andManifestNamedQueryName
is the name of the named query used to retrieve images for a manifestOn top of this, there is an SQS setting for listening to the batch completion queue, and the background handler needs access to the storage bucket:
Additionally, there is a small change to
paintedResource
to fill out anasset
with anassetId
as opposed tocanvasPainting
. i.e.: