Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix null behavior returning internal server error #211

Merged
merged 5 commits into from
Jan 10, 2025

Conversation

JackLewis-digirati
Copy link
Collaborator

@JackLewis-digirati JackLewis-digirati commented Dec 13, 2024

resolves #165

This PR creates a fallback value of false for behavior extension methods, causing them to not throw an error when behavior is null

@JackLewis-digirati JackLewis-digirati changed the title Fix/behavior internal server error Fix null behavior returning internal server error Dec 13, 2024
@JackLewis-digirati JackLewis-digirati force-pushed the fix/behaviorInternalServerError branch 2 times, most recently from 3cf3d5d to 33ac80f Compare December 16, 2024 16:12
@JackLewis-digirati JackLewis-digirati marked this pull request as ready for review December 16, 2024 16:19
Copy link
Member

@donaldgray donaldgray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - worth having unit tests for BehaviorX ?

@JackLewis-digirati JackLewis-digirati force-pushed the fix/behaviorInternalServerError branch from 9abc41d to 63171c9 Compare January 10, 2025 09:48
@JackLewis-digirati JackLewis-digirati merged commit 42a318b into main Jan 10, 2025
4 checks passed
@JackLewis-digirati JackLewis-digirati deleted the fix/behaviorInternalServerError branch January 10, 2025 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating IIIF collection without "behaviour" results in 500
2 participants