Minor updates #194
Merged
Minor updates #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was a class specific to Protagonist and parsing objects from different regions but this won't be used here
Extension was marked [Obsolete] in previous commit, removing
Change seed from most -> least random value to avoid identities that look similar (start with same 5-7 chars)
donaldgray
requested review from
p-kaczynski,
griffri and
JackLewis-digirati
JackLewis-digirati
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR isn't changing any API endpoint behaviour, purely internal updates:
RegionalisedObjectInBucket- this is specific toprotagonistfor parsing incoming origins and not required here (also contains some logic to maintained backwards compat withdeliveratorwhich we don't want to spread).IdentityManagerin favour ofGenerateUniqueIdAsyncextension method, which was marked[Obsolete]in CreatepaintedResourcesfor external items #193)