feat: Add set & get deviceInfo & datatype #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
yeah I think (1) is easier to work with. if we don't need querying then the JSON sounds good to me. |
achou11
reviewed
Sep 6, 2023
Ok changes made, it's ready to review again. |
Non-mapeo doc tables mustn't have the same name as mapeo doc tables
achou11
approved these changes
Sep 7, 2023
gmaclennan
added a commit
that referenced
this pull request
Sep 19, 2023
* main: chore: condense setup code in MemberAPI tests (#267) chore: replace queries opt in MemberAPI with dataType (#266) feat: add getMany method to member api (#263) feat: add getById method to member api (#262) chore: Update @digidem/types and remove patch (#269) feat: share all core keys via extension messages (#264) feat: send core "haves" bitfield on first connect (#254) fix: invite.encryptionKeys should be required (#260) feat: Add set & get deviceInfo & datatype (#250) expose member namespace in MapeoProject (#253) blobStore.createReadStream should not wait (#243) update MapeoManager to return and handle project public IDs (#247) return content hash from blobApi.create (#242)
This was referenced Nov 16, 2023
This was referenced Apr 11, 2024
This was referenced Jun 20, 2024
This was referenced Jul 25, 2024
This was referenced Aug 21, 2024
This was referenced Aug 29, 2024
This was referenced Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes initial implementation #249. It adds an internal datatype for
deviceInfoon the project instance, so that it can be used by the$membernamespace for reading and writing member info. This part has no tests yet because it's best to test the$membermethods once they are available.This also adds
client.setDeviceInfo()andclient.getDeviceInfo()methods, along with a new table in the client db for storing this info.I wasn't too sure about how to store this in SQLite. We will only ever have one deviceInfo record, so options are:
i. A column for each property
ii A single JSON column with all info
I went with (2), but having done it I think (1) with a JSON column might be the better / simpler option.